Skip to content

Revert change to production deploy script to build only on tag #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

catarak
Copy link
Member

@catarak catarak commented Nov 12, 2021

I made a change so that the production deployment would only happen when a tag is pushed, but it's not working. Reverting to the old way to build when pushing to release for now.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak catarak merged commit 6587ef3 into release Nov 12, 2021
@release-com
Copy link

release-com bot commented Nov 12, 2021

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

  • p5.js-web-editor

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-9ad484d13c

@raclim raclim deleted the bug/production-deploy branch June 7, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant