Skip to content

Resolved Issue no #934 #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 15, 2021
Merged

Resolved Issue no #934 #1916

merged 5 commits into from
Sep 15, 2021

Conversation

brijsiyag
Copy link
Contributor

@brijsiyag brijsiyag commented Aug 19, 2021

Fixes #934

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #934

@welcome
Copy link

welcome bot commented Aug 19, 2021

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@release-com
Copy link

release-com bot commented Aug 19, 2021

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-6dc1d1a674

@catarak
Copy link
Member

catarak commented Sep 14, 2021

Thanks for working on this issue! I was testing this out, and it was working great. However, after looking at the code, I realized that I didn't agree with the approach—I thought that the code should be removed from the React component and into the console reducer, as redux is responsible for managing data changes.

After making this change locally, I couldn't get the styling quite write—as the times count got really bug, it obscured the console message. I dug around into the console-feed library, and it turns out this functionality is now built in! So yeah, that's the reasoning behind all of these changes I made.

@catarak

This comment has been minimized.

@catarak
Copy link
Member

catarak commented Sep 15, 2021

Create Release Environment

@catarak catarak merged commit fc1a9fb into processing:develop Sep 15, 2021
@catarak catarak mentioned this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge together the exact same console events
2 participants