Skip to content

Fixed #1857 - In Find, "only whole words" also finds postfixes #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2021

Conversation

divyanx
Copy link
Contributor

@divyanx divyanx commented Aug 19, 2021

Fixes #1857

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. `Fixes In Find, "only whole words" also finds postfixes #1857

Screenshot 2021-08-19 at 9 37 00 AM

Correct the find functionality for whole words which was previously returning even if the suffix of a string was matching the word. e.g. "abcdef" would previously match with "def" even when whole word is on.
Do code cleanups before pull request
@welcome
Copy link

welcome bot commented Aug 19, 2021

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link

@razorblade42 razorblade42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for it ! it finally works!

@divyanx
Copy link
Contributor Author

divyanx commented Aug 19, 2021

Thanks for it ! it finally works!

Hope it gets merged, as it's my first pull request.

@catarak
Copy link
Member

catarak commented Nov 3, 2021

Thanks so much for working on this! Working great for me.

@catarak catarak merged commit 8513dca into processing:develop Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Find, "only whole words" also finds postfixes
3 participants