-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add the zh-TW language translation. #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the zh-TW (Traditional Chinese) language translation for P5 Web Editor. On branch develop Your branch is up to date with 'origin/develop'. Changes to be committed: modified: client/components/Nav.jsx modified: client/i18n.js modified: package-lock.json new file: translations/locales/zh-TW/translations.json
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Release EnvironmentsThis pull request environment is provided by Release, learn more!
🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-65b1729218 |
Hi @codemee! Thank you for working on this translation. Lots of folks are adding new translations, which is super exciting, but I'm also concerned with the maintenance of these translations—for example, if there are UI changes that add new copy, this copy needs to be added across all of the translations as well. Since there is already a Simplified Chinese translation, I'm curious about
Thank you for your help! @limzykenneth @Qianqianye it would also be helpful if y'all weighed in 😄 |
Hi
In fact, here in Flag Tech, we are designing a studying kit for teaching ML5.js using P5.js Editor for interacting with micro-controlled board. So we are look foward to Traditional Chinese version of P5.js Editor. Thanks. |
I do very much look forward to having Traditional Chinese translation in p5.js (for the p5.js website when I was working on Simplified Chinese) but just never got around to it, partly because I can't find the time, partly because as @codemee mentioned, terms used in Simplified Chinese and Traditional Chinese are often different so it couldn't be a simple direct transform from the Simplified script to the Traditional script. I think @codemee's answers are pretty good, I'm just going to expand a bit from my end. I'm kind of a weird case with my background and I'm able to understand both Simplified and Traditional Chinese so I can't say much about whether other Chinese users are able to do the same as well. As pointed out above, the difference in terms used can become a source of confusion for some users. I started learning coding by reading materials in both scripts and I got used to the differences but I can imagine it being a roadblock if the materials you have on hand contradicts what p5.js uses. It is an interesting problem as the two usually is managed as two separate languages while being for the most part the same language, from the maintenance perspective though I think it is better to see them as two separate languages. |
thank you so much @codemee and @limzykenneth for explaining the differences! this is really, really helpful—seems like it's absolutely the right option to support both translations. one last question—I know @almchung has been working on translations for the p5.js friendly errors, and we'd like to change the language of the friendly errors when the language in the p5.js editor is set. if the friendly errors only have a Simplified Chinese translation, would it make sense to display that translation if Traditional Chinese is selected, or would that be super confusing and it would instead make sense to display the default English instead?
this is so awesome! please share with the p5.js team whenever you would like: hello@p5js.org |
I would suggest displaying default English in this case. Essentially like I said above, treating them as two different languages works most of the time. |
It is exciting to see a new translation added to p5! @catarak @limzykenneth i18next, which FES translations are based on, provides the fallback option and even allows us to keep the fallbacks different per region (LINK) so this should cause no problem. |
How can I help to also translate the errors into Traditional Chinese?
Thanks.
Cassie Tarakajian ***@***.***> 於 2021年9月15日 週三 01:49 寫道:
… thank you so much @codemee <https://github.com/codemee> and @limzykenneth
<https://github.com/limzykenneth> for explaining the differences! this is
really, really helpful—seems like it's absolutely the right option to
support both translations.
one last question—I know @almchung <https://github.com/almchung> has been
working on translations for the p5.js friendly errors, and we'd like to
change the language of the friendly errors when the language in the p5.js
editor is set. if the friendly errors only have a Simplified Chinese
translation, would it make sense to display that translation if Traditional
Chinese is selected, or would that be super confusing and it would instead
make sense to display the default English instead?
In fact, here in Flag Tech <https://www.flag.com.tw/maker/pd>, we are
designing a studying kit for teaching ML5.js using P5.js Editor for
interacting with micro-controlled board. So we are look foward to
Traditional Chinese version of P5.js Editor.
this is so awesome! please share with the p5.js team whenever you would
like: ***@***.***
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1912 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5MWIB74QOHU47IL3GE43UB6DJ5ANCNFSM5BTCZDIA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@almchung |
Add the zh-TW (Traditional Chinese) language translation for P5 Web Editor.
On branch develop
Your branch is up to date with 'origin/develop'.
Changes to be committed:
modified: client/components/Nav.jsx
modified: client/i18n.js
modified: package-lock.json
new file: translations/locales/zh-TW/translations.json
Fixes #issue-number
I have verified that this pull request:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)Fixes #123