Skip to content

Fixes #1867 - Color picker feature #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2021
Merged

Conversation

ameybh
Copy link
Contributor

@ameybh ameybh commented Jul 20, 2021

Fix #1867

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Demo:

p5 2-2021-07-20_13 08 09

Features:

  • Shows a color picker option when RGB or hex values are used.
  • metaKey+K shortcut to popup color picker anywhere in the editor.

Issues:

  • The tiny color view square doesn't update when colors are changed. This might be because of incompatibility between colorpicker-codemirror and this project. The colorview updates perfectly on simple example demos.

ameybh added 2 commits July 20, 2021 12:49
* shows a color pick option when using hex codes or rgb values
* invoke color picker using Ctrl+K
@welcome
Copy link

welcome bot commented Jul 20, 2021

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@release-com
Copy link

release-com bot commented Jul 20, 2021

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-5550122a5a

@ameybh ameybh marked this pull request as draft July 20, 2021 08:51
@ameybh ameybh marked this pull request as ready for review July 20, 2021 09:08
@ameybh ameybh mentioned this pull request Aug 20, 2021
@catarak catarak merged commit 1f21a9b into processing:develop Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Color picker
2 participants