Skip to content

Fixes #1813 #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Conversation

gugray
Copy link
Contributor

@gugray gugray commented May 12, 2021

Fixes #1813

As per comment #1813 (comment) I went with option 2. I.e., when you click "New sketch" on the Dashboard, it was previous just a navigation that preserved the current project. Now the button has a handler that calls newProject().

I did not choose option 1, because I think that's less consistent. Namely: when you have a sketch that is saved and go to the Dashobard, the current project is preserved. If you hit "back to sketch" or explicitly navigate to the base URL, the sketch will still be there. By choosing option 1, the same behavior remains with unsaved sketches.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented May 12, 2021

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Member

@catarak catarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great for me! Thank you for working on this.

@catarak catarak merged commit 9f9ff88 into processing:develop Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new sketch option doesn't work from sketch tab
2 participants