Skip to content

test that startSketch must have been called when play button is clicked #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vulongphan
Copy link
Contributor

Fixes #1823

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@release-com
Copy link

release-com bot commented Mar 26, 2021

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

p5.js-web-editor
app-tedfdc4-p5-js-web-editor.releaseapp.io

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-24e2506d22

@catarak
Copy link
Member

catarak commented May 5, 2021

Thanks for working on this! You have some extraneous changes to package.json and package-lock.json that shouldn't be in this PR.

@catarak catarak merged commit 481f80e into processing:develop Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for play button
2 participants