-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Portuguese Translation #1810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portuguese Translation #1810
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
This is full Portuguese translation. Many people in Brazil work with JavaScript projects and editors, and I've been noticing a huge lack of properly translated ones. I really like and frequently use p5.js, and I think a translation will be very much appreciated by the Portuguese speakers community. I'm half Brazilian, so I'm legit lol. This is my first PR btw. |
Release Environmentsp5.js-web-editor |
@byfelipesanchez this is so awesome and thank you for working on this!!! I can't wait to merge this in. Have you had anyone review your translation? Do you know of anyone who could review it? You can either send them your JSON file or you can use the staging link for this PR: app-tedc41c-p5-js-web-editor.releaseapp.io Going to tag @ghalestrilo just in case he has time to look this over :) |
I got a couple of Brazilian friends to review it. Is that enough? @catarak |
@byfelipesanchez yes! that's perfect. obviously updates can be made via PRs in the future but I just wanted to make sure the translation is in a good place now! |
got you! Thanks for checking it! :) |
Fixes #issue-number
I have verified that this pull request:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)Fixes #123