Skip to content

Portuguese Translation #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2021
Merged

Portuguese Translation #1810

merged 4 commits into from
May 5, 2021

Conversation

felipesanchezz
Copy link
Contributor

Fixes #issue-number

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Mar 15, 2021

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@felipesanchezz
Copy link
Contributor Author

This is full Portuguese translation. Many people in Brazil work with JavaScript projects and editors, and I've been noticing a huge lack of properly translated ones. I really like and frequently use p5.js, and I think a translation will be very much appreciated by the Portuguese speakers community. I'm half Brazilian, so I'm legit lol. This is my first PR btw.

@release-com
Copy link

release-com bot commented Mar 15, 2021

Release Environments

p5.js-web-editor
app-tedc41c-p5-js-web-editor.releaseapp.io

@catarak
Copy link
Member

catarak commented May 4, 2021

@byfelipesanchez this is so awesome and thank you for working on this!!! I can't wait to merge this in. Have you had anyone review your translation? Do you know of anyone who could review it? You can either send them your JSON file or you can use the staging link for this PR: app-tedc41c-p5-js-web-editor.releaseapp.io

Going to tag @ghalestrilo just in case he has time to look this over :)

@felipesanchezz
Copy link
Contributor Author

@byfelipesanchez this is so awesome and thank you for working on this!!! I can't wait to merge this in. Have you had anyone review your translation? Do you know of anyone who could review it? You can either send them your JSON file or you can use the staging link for this PR: app-tedc41c-p5-js-web-editor.releaseapp.io

Going to tag @ghalestrilo just in case he has time to look this over :)

I got a couple of Brazilian friends to review it. Is that enough? @catarak

@catarak
Copy link
Member

catarak commented May 5, 2021

@byfelipesanchez yes! that's perfect. obviously updates can be made via PRs in the future but I just wanted to make sure the translation is in a good place now!

@catarak catarak merged commit 5e0af56 into processing:develop May 5, 2021
@felipesanchezz
Copy link
Contributor Author

@byfelipesanchez yes! that's perfect. obviously updates can be made via PRs in the future but I just wanted to make sure the translation is in a good place now!

got you! Thanks for checking it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants