Skip to content

Switching to prettier from beautify js #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

satyasaibhushan
Copy link
Contributor

Fixes #1223

I have verified that this pull request:

  • [*] has no linting errors (npm run lint)
  • [*] is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • [*] is descriptively named and links to an issue number, i.e. Fixes #123

I've attached a screenshot of unwanted behaviour in the issue
Here I'm attaching a desired behaviour one

Screen.Recording.2021-03-05.at.12.57.21.AM.mov
also removed errors occurring due to syntax error

@release-com
Copy link

release-com bot commented Mar 4, 2021

Release Environments

p5.js-web-editor
app-ted477a-p5-js-web-editor.releaseapp.io

@satyasaibhushan
Copy link
Contributor Author

Hey @catarak,
If you agree with me with above comments, I can add another commit to this

@catarak
Copy link
Member

catarak commented Mar 5, 2021

Didn't notice your comment until now, just pushed the changes you mentioned. Look good to you?

@satyasaibhushan
Copy link
Contributor Author

Perfect!

@catarak catarak merged commit b6068b5 into processing:develop Mar 10, 2021
@satyasaibhushan satyasaibhushan deleted the switching_to_prettier_from_beautify-js branch March 11, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep cursor position when tidying code
2 participants