Skip to content

Removes setTimeout for setting cursor's position. #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

namanarora00
Copy link
Contributor

Fixes #1705

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #1705

I did encounter some warnings on running npm run lint but I believe these are being taken care of in another PR. The changes I've made do not create any new warnings.

@welcome
Copy link

welcome bot commented Dec 15, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Member

@catarak catarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great for me! I just noticed that the Sublime keymap is unindenting the code when you use the keyboard shortcut to run tidy code so I removed it too.

@catarak catarak merged commit 7f4e87a into processing:develop Dec 15, 2020
@namanarora00
Copy link
Contributor Author

Thanks for dealing with this, @catarak. While this is fine do you think instead of deleting the keymap we could change the keyboard shortcut for tidy itself since Shift+Tab is a commonly used shortcut for unindenting?

@catarak
Copy link
Member

catarak commented Dec 16, 2020

@namanarora00 yes! I'm gonna open a new issue for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lag in bringing the cursor back to it's original postion after tidy operation.
2 participants