Skip to content

Improved keyboard accessibility of the find-replace popup #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 11, 2020

Conversation

SundeepChand
Copy link
Contributor

Fixes #1699
I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Hello @catarak. Please review my work and please verify the Spanish & Japanese translations of 'Toggle Replace'.

@catarak
Copy link
Member

catarak commented Dec 4, 2020

@koji can you verify the Japanese translation?

@oruburos can you verify the Spanish translation?

Thank you!!

@oruburos
Copy link
Collaborator

oruburos commented Dec 4, 2020

@catarak All good in the Spanish translation.

@koji
Copy link
Contributor

koji commented Dec 4, 2020

@catarak I would recommend this, 置換の切り替え instead of the current トグル置換.
@SundeepChand, could you change this ↑, please?

By the way, thank you for the release, one person told me that the translation has been released.
https://twitter.com/takawo/status/1329613670188367872

@SundeepChand
Copy link
Contributor Author

Hello @koji, Thanks for your suggestions. I've updated the same.

@catarak
Copy link
Member

catarak commented Dec 7, 2020

Thanks for adding those changes @SundeepChand! I was testing the JS changes that you made, and I noticed that now when I click on the "Replace" button, the replace doesn't happen, but it does work when I click "Replace All".

@SundeepChand
Copy link
Contributor Author

Thanks @catarak for pointing this out, this bug is there in production as well. Its fixed now.

@catarak catarak merged commit 7ec42a6 into processing:develop Dec 11, 2020
@SundeepChand SundeepChand deleted the feat/kbd-access branch December 12, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve keyboard accessibility of the find-replace popup
4 participants