-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Improved keyboard accessibility of the find-replace popup #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@catarak All good in the Spanish translation. |
@catarak I would recommend this, By the way, thank you for the release, one person told me that the translation has been released. |
c81a120
to
b1dd908
Compare
Hello @koji, Thanks for your suggestions. I've updated the same. |
Thanks for adding those changes @SundeepChand! I was testing the JS changes that you made, and I noticed that now when I click on the "Replace" button, the replace doesn't happen, but it does work when I click "Replace All". |
Thanks @catarak for pointing this out, this bug is there in production as well. Its fixed now. |
Fixes #1699
I have verified that this pull request:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)Fixes #123
Hello @catarak. Please review my work and please verify the Spanish & Japanese translations of 'Toggle Replace'.