Skip to content

Fix/cant see shaders code #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2020

Conversation

vulongphan
Copy link
Contributor

Fixes #1595

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak
Copy link
Member

catarak commented Nov 23, 2020

Thank you for working on this! It's working for me. I know that the code in this script is a little messy, but would it be possible for you to put the new code you added into a separate function? I think eventually it would make sense to clean up this file, but for now, when adding new code, I think it makes sense to add it in as cleanly as possible.

@vulongphan
Copy link
Contributor Author

Yes, it makes sense to me too. I have moved all my added code to addAssetsToProject(). Could you please have a look?

Copy link
Member

@catarak catarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change! Looks good to me.

@catarak
Copy link
Member

catarak commented Nov 24, 2020

This is working great for me. I think the next important step here is refactoring this file so that it just uses async/await—there are callbacks, promises, and async/await here and it's kind of a mess :) I'll open a new issue!

@catarak catarak merged commit 6edd547 into processing:develop Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't see shaders code
2 participants