-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update installation doc regarding Github API configuration #1678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation doc regarding Github API configuration #1678
Conversation
@catarak I have committed new changes based on your requested changes. Could you please have a look to make sure the documentation is clear and adequate? |
Thanks for incorporating the changes! I think you should link to the GitHub API Section from the installation steps rather than the other way around—I think it will be more clear to someone going through the installation for the first time! |
…ked to manual and docker installation
Yeah, it makes sense to me too, this way it is easier to navigate for someone going through the documentation for the first time. I also updated the document according to this. Could you please check the most recent commit (id: d1f5de4) and tell me if it is okay? |
…ked to manual and docker installation
…ked to manual and docker installation
@catarak sorry for the broken link, I have fixed it in my most recent commit. |
Thank you for working on this! I updated the copy a little but more 😄 |
Fixes #1679
I have verified that this pull request:
npm run lint
)develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too)Fixes #123