Skip to content

Update installation doc regarding Github API configuration #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 19, 2020

Conversation

vulongphan
Copy link
Contributor

@vulongphan vulongphan commented Nov 16, 2020

Fixes #1679

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@vulongphan
Copy link
Contributor Author

@catarak I have committed new changes based on your requested changes. Could you please have a look to make sure the documentation is clear and adequate?

@catarak
Copy link
Member

catarak commented Nov 17, 2020

Thanks for incorporating the changes! I think you should link to the GitHub API Section from the installation steps rather than the other way around—I think it will be more clear to someone going through the installation for the first time!

@vulongphan
Copy link
Contributor Author

vulongphan commented Nov 17, 2020

Yeah, it makes sense to me too, this way it is easier to navigate for someone going through the documentation for the first time. I also updated the document according to this. Could you please check the most recent commit (id: d1f5de4) and tell me if it is okay?

@vulongphan
Copy link
Contributor Author

@catarak sorry for the broken link, I have fixed it in my most recent commit.

@catarak
Copy link
Member

catarak commented Nov 19, 2020

Thank you for working on this! I updated the copy a little but more 😄

@catarak catarak merged commit a9ddb48 into processing:develop Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credentials for Github Apps cannot be used to download examples sketch for p5 user in local development
2 participants