Fix #358 - migrate to S3 policy v4 to support AWS4-HMAC-SHA256 #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
Thank you so much for working on this! I think it's okay to not get this to work for non-Amazon S3 buckets at the moment—just opening this up to different regions is super useful, as folks are running into this issue often! |
catarak
approved these changes
Sep 11, 2020
|
Still quite some changes, but great you managed to get it working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #358 so that it works on more AWS regions. I hope it fits your development guidelines, I'm not too acquainted with JS. For some reason I still didn't manage to get it running on non-Amazon S3 services.
I have verified that this pull request:
npm run lint)Fixes #123