Skip to content

Add new file/folder bugfix #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2020
Merged

Add new file/folder bugfix #1602

merged 3 commits into from
Sep 4, 2020

Conversation

neelesh7singh
Copy link
Contributor

Fixes #1003
I'm adding an event listener whenever newFile or newFolder model is opened which close the models if clicked outside the models.
I have also changed the ide reducer a little bit so that both models can't be opened at the same time in anyways.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak
Copy link
Member

catarak commented Sep 4, 2020

Thanks for working on this! Woking great for me.

@catarak catarak merged commit 9ef9075 into processing:develop Sep 4, 2020
@neelesh7singh neelesh7singh deleted the add-new-file/folder-bugfix branch September 4, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file and add folder dialog can be opened at the same time
2 participants