Skip to content

Summary translations for Tables in Collection, CollectionList, and SketchList #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2020
Merged

Summary translations for Tables in Collection, CollectionList, and SketchList #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51667bb
Summary translations for Collection, CollectionList, and SketchList
oruburos Sep 4, 2020
0a92dad
Merge remote-tracking branch 'remotes/upstream/develop' into summary_…
oruburos Sep 4, 2020
856de09
Fixes missing translation Toolbar by
oruburos Sep 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/modules/IDE/components/CollectionList/CollectionList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class CollectionList extends React.Component {
{this._renderLoader()}
{this._renderEmptyTable()}
{this.hasCollections() &&
<table className="sketches-table" summary="table containing all collections">
<table className="sketches-table" summary={this.props.t('CollectionList.TableSummary')}>
<thead>
<tr>
{this._renderFieldHeader('name', this.props.t('CollectionList.HeaderName'))}
Expand Down
2 changes: 1 addition & 1 deletion client/modules/IDE/components/SketchList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ class SketchList extends React.Component {
{this._renderLoader()}
{this._renderEmptyTable()}
{this.hasSketches() &&
<table className="sketches-table" summary="table containing all saved projects">
<table className="sketches-table" summary={this.props.t('SketchList.TableSummary')}>
<thead>
<tr>
{this._renderFieldHeader('name', this.props.t('SketchList.HeaderName'))}
Expand Down
2 changes: 1 addition & 1 deletion client/modules/IDE/components/Toolbar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ class Toolbar extends React.Component {
if (this.props.owner) {
return (
<p className="toolbar__project-owner">
by <Link to={`/${this.props.owner.username}/sketches`}>{this.props.owner.username}</Link>
{this.props.t('Toolbar.By')} <Link to={`/${this.props.owner.username}/sketches`}>{this.props.owner.username}</Link>
</p>
);
}
Expand Down
2 changes: 1 addition & 1 deletion client/modules/User/components/Collection.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ class Collection extends React.Component {
<div className="collection-table-wrapper">
{this._renderEmptyTable()}
{this.hasCollectionItems() &&
<table className="sketches-table" summary="table containing all collections">
<table className="sketches-table" summary={this.props.t('Collection.TableSummary')}>
<thead>
<tr>
{this._renderFieldHeader('name', this.props.t('Collection.HeaderName'))}
Expand Down
6 changes: 5 additions & 1 deletion translations/locales/en-US/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
"PlayOnlyVisualSketchARIA": "Play only visual sketch",
"StopSketchARIA": "Stop sketch",
"EditSketchARIA": "Edit sketch name",
"NewSketchNameARIA": "New sketch name"
"NewSketchNameARIA": "New sketch name",
"By": " by "
},
"Console": {
"Title": "Console",
Expand Down Expand Up @@ -407,6 +408,7 @@
"NumSketches_plural": "{{count}} sketches",
"By":"Collection by ",
"NoSketches": "No sketches in collection",
"TableSummary": "table containing all collections",
"HeaderName": "Name",
"HeaderCreatedAt": "Date Added",
"HeaderUser": "Owner",
Expand Down Expand Up @@ -445,6 +447,7 @@
"Title": "p5.js Web Editor | My collections",
"AnothersTitle": "p5.js Web Editor | {{anotheruser}}'s collections",
"NoCollections": "No collections.",
"TableSummary": "table containing all collections",
"HeaderName": "Name",
"HeaderCreatedAt": "Date Created",
"HeaderCreatedAt_mobile": "Created",
Expand Down Expand Up @@ -487,6 +490,7 @@
"ButtonLabelAscendingARIA": "Sort by {{displayName}} ascending.",
"ButtonLabelDescendingARIA": "Sort by {{displayName}} descending.",
"AddToCollectionOverlayTitle": "Add to collection",
"TableSummary": "table containing all saved projects",
"HeaderName": "Sketch",
"HeaderCreatedAt": "Date Created",
"HeaderCreatedAt_mobile": "Created",
Expand Down
6 changes: 5 additions & 1 deletion translations/locales/es-419/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
"PlayOnlyVisualSketchARIA": "Ejecutar bosquejo visual",
"StopSketchARIA": "Detener bosquejo",
"EditSketchARIA": "Editar nombre de bosquejo",
"NewSketchNameARIA": "Nuevo nombre de bosquejo"
"NewSketchNameARIA": "Nuevo nombre de bosquejo",
"By": " de "
},
"Console": {
"Title": "Consola",
Expand Down Expand Up @@ -407,6 +408,7 @@
"NumSketches_plural": "{{count}} bosquejos",
"By":"Colección por ",
"NoSketches": "No hay bosquejos en la colección",
"TableSummary": "tabla que contiene todas las colecciones",
"HeaderName": "Nombre",
"HeaderCreatedAt": "Fecha de agregación",
"HeaderUser": "Propietario",
Expand Down Expand Up @@ -445,6 +447,7 @@
"Title": "p5.js Web Editor | Mis colecciones",
"AnothersTitle": "Editor Web p5.js | Colecciones de {{anotheruser}}",
"NoCollections": "No hay colecciones.",
"TableSummary": "la tabla contiene todas las colecciones",
"HeaderName": "Nombre",
"HeaderCreatedAt": "Fecha Creación",
"HeaderCreatedAt_mobile": "Creación",
Expand Down Expand Up @@ -487,6 +490,7 @@
"ButtonLabelAscendingARIA": "Ordenar por {{displayName}} ascendente.",
"ButtonLabelDescendingARIA": "Ordenar por {{displayName}} descendente.",
"AddToCollectionOverlayTitle": "Agregar a colección",
"TableSummary": "la tabla contiene todos los proyectos guardados",
"HeaderName": "Bosquejo",
"HeaderCreatedAt": "Fecha Creación",
"HeaderCreatedAt_mobile": "Creación",
Expand Down