Skip to content

✨ add toast to MobileIDEView #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 15, 2020

Conversation

ghalestrilo
Copy link
Collaborator

Fixes #1596

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak
Copy link
Member

catarak commented Sep 3, 2020

Looking great 😄 What would you think about placing the toast under the header? I don't know how I feel about it blocking the title. Maybe the text could also be smaller on mobile?

@ghalestrilo
Copy link
Collaborator Author

Sure! I did it, and it does look better, but I wanna hear your thoughts on this:

  1. It still covers the first two lines of code
  2. Mobile apps usually have a pop-up banner above the header, to indicate lack of connectivity, or similar infrequent info. I was thinking of this as an alternative?

@catarak
Copy link
Member

catarak commented Sep 4, 2020

Sure! I did it, and it does look better.

I agree it does look better! Also agree that it is annoying that it covers the first two lines of code.

  1. Mobile apps usually have a pop-up banner above the header, to indicate lack of connectivity, or similar infrequent info. I was thinking of this as an alternative?

Do you have some examples we could use as a visual reference?

@ghalestrilo
Copy link
Collaborator Author

ghalestrilo commented Sep 9, 2020

I thought of doing something like this, except pushing everything down a bit. In hindsight, not a brilliant idea :^)
I've seen a couple of apps placing the toast to the bottom, it's an alternative. Tell me which option feels best, and we'll go from there
image

edit.: changed the example - it's best not to hide the bottom bar with the toast

@catarak
Copy link
Member

catarak commented Sep 9, 2020

I like how it looks at the bottom! It feels less intrusive, I like that it's closer to reach with your thumb so that you can get rid of it if you want to, but it also doesn't feel like it's in a location that it won't be noticed.

@ghalestrilo
Copy link
Collaborator Author

I think it looks nicer now, check it out!

@catarak
Copy link
Member

catarak commented Sep 11, 2020

For me, this is what the toast looks like:
Screen Shot 2020-09-11 at 6 06 19 PM

@ghalestrilo
Copy link
Collaborator Author

lord, I forgot a css rule. definitely not a design choice!

Copy link
Member

@catarak catarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one last change so that the toast doesn't sit right up against the edges, which looked strange with the border radius. Now this is ready to be merged in!

@ghalestrilo ghalestrilo merged commit 51ee416 into processing:develop Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save Sketch Toast on Mobile
2 participants