-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
✨ add toast to MobileIDEView #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add toast to MobileIDEView #1597
Conversation
Looking great 😄 What would you think about placing the toast under the header? I don't know how I feel about it blocking the title. Maybe the text could also be smaller on mobile? |
Sure! I did it, and it does look better, but I wanna hear your thoughts on this:
|
I agree it does look better! Also agree that it is annoying that it covers the first two lines of code.
Do you have some examples we could use as a visual reference? |
I thought of doing something like this, except pushing everything down a bit. In hindsight, not a brilliant idea :^) edit.: changed the example - it's best not to hide the bottom bar with the toast |
I like how it looks at the bottom! It feels less intrusive, I like that it's closer to reach with your thumb so that you can get rid of it if you want to, but it also doesn't feel like it's in a location that it won't be noticed. |
I think it looks nicer now, check it out! |
lord, I forgot a css rule. definitely not a design choice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made one last change so that the toast doesn't sit right up against the edges, which looked strange with the border radius. Now this is ready to be merged in!
Fixes #1596
I have verified that this pull request:
npm run lint
)Fixes #123