Skip to content

[#1593] Update isExpanded prop in Editor #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

catarak
Copy link
Member

@catarak catarak commented Sep 2, 2020

  • Change isExpanded from ide.consoleIsExpanded to
    ide.sidebarIsExpanded

Fixes #1593

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

- Change `isExpanded` from `ide.consoleIsExpanded` to
  `ide.sidebarIsExpanded`
@catarak catarak merged commit b7ab455 into develop Sep 2, 2020
@montoyamoraga
Copy link
Member

@catarak, i am going through the branches, i think this one is ready to be deleted :)

@catarak catarak deleted the bug/sidebar-cant-expand branch December 17, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expanding and Collapsing the Sidebar is not working
2 participants