Skip to content

Adding Translation Keys in QuickAddList Component #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2020
Merged

Adding Translation Keys in QuickAddList Component #1571

merged 1 commit into from
Aug 26, 2020

Conversation

oruburos
Copy link
Collaborator

Fixes #1570

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number`

@oruburos
Adding Keys in QuickAddList Component
be3408a 
Renaming thoseKeys to follow naming conventions for ARIA labels.
@oruburos
Copy link
Collaborator Author

@andrewn Can you have a look at this, please?

andrewn
andrewn approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@andrewn andrewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrewn andrewn merged commit 4d04952 into processing:develop Aug 26, 2020
@ceciliahollins ceciliahollins mentioned this pull request Feb 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewn andrewn andrewn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/remove collection buttons not translated
2 participants
@oruburos @andrewn