Spanish Translations: FileUploader, Error Modal, Share Modal #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leModal # Conflicts: # translations/locales/en-US/translations.json # translations/locales/es-419/translations.json
andrewn
suggested changes
Aug 20, 2020
| If you would like to upload more, please remove the ones you aren't using anymore by | ||
| in your ` | ||
| } | ||
| {this.props.t('UploadFileModal.SizeLimitError')} |
There was a problem hiding this comment.
UploadFileModal.SizeLimitError interpolates limitText but it's not provided as a parameter to t()
| "UploadFileModal": { | ||
| "Title": "Upload File", | ||
| "CloseButtonARIA": "Close upload file modal", | ||
| "SizeLimitError": "Error: You cannot upload any more files. You have reached the total size limit of ${limitText}.\n If you would like to upload more, please remove the ones you aren't using anymore by\n in your " |
There was a problem hiding this comment.
This is the incorrect way to interpolate limitText into this message.
andrewn
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this pull request:
npm run lint)It provides the translation for uploading files, error modals and share modal.