Skip to content

Fixed "Add Sketch to Collection" Popup styling bug on Dark and High Contrast themes #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 19, 2020

Conversation

SundeepChand
Copy link
Contributor

Fixes #1542

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@SundeepChand SundeepChand changed the title Bugfix/popupstyle Fixed "Add Sketch to Collection" Popup styling bug on Dark and High Contrast themes Aug 18, 2020
@catarak
Copy link
Member

catarak commented Aug 19, 2020

Looks good to me! While I was reviewing this, I also added some other minor changes to match the QuickAddList table styling to match the SketchList/CollectionList, by adding a border.

@catarak catarak merged commit 45a4e54 into processing:develop Aug 19, 2020
@SundeepChand SundeepChand deleted the bugfix/popupstyle branch August 21, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add Sketch to Collection" Popup styling bug on Dark and High Contrast themes
2 participants