Spanish Translation Account form and New Password #1547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking very good. @oruburos Can you fix the merge conflicts in this branch and then let me know when it's done please? |
|
@andrewn Hi, I've merged the most recent develop branch with this PR to solve the conflicts, can you have a look please? |
andrewn
suggested changes
Aug 13, 2020
| @@ -39,7 +39,8 @@ class APIKeyForm extends React.Component { | |||
| } | |||
|
|
|||
| removeKey(key) { | |||
| const message = `Are you sure you want to delete "${key.label}"?`; | |||
| // const message = `Are you sure you want to delete "${}"?`; | |||
| const message = i18next.t('APIKeyForm.ConfirmDelete', { key_label: key.label }); | |||
There was a problem hiding this comment.
This should use withTranslation, not i18next as it's within a component.
There was a problem hiding this comment.
Ok, the change requested it is complete, can you check this please?
There was a problem hiding this comment.
You also need to remove the i18next import from the top of the file as it's no longer used. The lint should be warning about this.
There was a problem hiding this comment.
Ok, the import is deleted, can you have a look please.?
Delete comments.
Delete unused imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this pull request:
npm run lint)This PR introduces Spanish Translation for the Account Form/View, ApiKeyForm and List and New Password Form/View