Skip to content

Add Dropdown Menu to the mobile IDE View #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
ac0c519
:construction: create <Dropdown /> component
ghalestrilo Jul 21, 2020
b3e88aa
Merge branch 'develop' of https://github.com/processing/p5.js-web-edi…
ghalestrilo Jul 21, 2020
24e6b36
:bento: create <MoreIcon />
ghalestrilo Jul 21, 2020
ca88c4e
:construction: put an invisible <Dropdown /> on MobileIDEView
ghalestrilo Jul 21, 2020
91a766d
:construction: import dropdown list style from scss
ghalestrilo Jul 22, 2020
c58cdc2
:construction: add navigation elements to the dropdown menu
ghalestrilo Jul 22, 2020
371e4cc
:alembic: create <OverlayManager /> component
ghalestrilo Jul 22, 2020
9f8b41c
:sparkles: make dropdown menu open and close
ghalestrilo Jul 24, 2020
9bebf9f
:twisted_rightwards_arrows: merge from develop
ghalestrilo Jul 24, 2020
0a065cb
:broom: unhide sidebar
ghalestrilo Jul 24, 2020
f7d0631
:ok_hand: remove isRequired from consoleEvents
ghalestrilo Jul 24, 2020
77a40a9
:ok_hand: rename last menu option to 'Original Editor'
ghalestrilo Jul 24, 2020
4abdc65
:twisted_rightwards_arrows: merge from develop
ghalestrilo Jul 28, 2020
f5e901a
:ok_hand: add CodeIcon to icons.jsx
ghalestrilo Jul 28, 2020
d2dcc1f
:ok_hand: restore Console.jsx classes
ghalestrilo Jul 28, 2020
dd37c77
:ok_hand: remove eslint-disable-lines
ghalestrilo Jul 28, 2020
f9c0e80
:bug: restore package-lock.json
ghalestrilo Jul 28, 2020
b8bdfd9
Merge branch 'develop' into feature/mobile-header-dropdown-menu
ghalestrilo Jul 28, 2020
8339be1
:recycle: create useHideOnBlur hook
ghalestrilo Jul 29, 2020
8da6497
:recycle: create useAsModal HOC
ghalestrilo Jul 29, 2020
e430652
:recycle: make dropdown left/rightable
ghalestrilo Jul 29, 2020
7c2a624
:firetruck: restore devtools sidebar
ghalestrilo Jul 29, 2020
10ccc19
:bug: update mobile nav paths
ghalestrilo Jul 29, 2020
ea9a2f9
:recycle: make li into styled component
ghalestrilo Jul 29, 2020
8acd6ec
:ok_hand: move hoc to components folder
ghalestrilo Jul 30, 2020
8225807
:ok_hand: subst left/right props with align prop on <Dropdown />
ghalestrilo Jul 30, 2020
7272afe
Merge branch 'develop' into feature/mobile-header-dropdown-menu
catarak Jul 30, 2020
ab93a4c
:ok_hand: make dropdown list toggle on enter/click
ghalestrilo Jul 30, 2020
ed989ee
Merge branch 'develop' of https://github.com/processing/p5.js-web-edi…
ghalestrilo Jul 31, 2020
78d4fc4
:ok_hand: remove eslint disable lines
ghalestrilo Jul 31, 2020
e1fd49b
:bug: fix dropdown defaulting to open
ghalestrilo Aug 3, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/modules/App/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ class App extends React.Component {
render() {
return (
<div className="app">
{this.state.isMounted && !window.devToolsExtension && getConfig('NODE_ENV') === 'development' && <DevTools />}
{/* FIXME: Remove false */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you want to remove this for this PR!

{false && this.state.isMounted && !window.devToolsExtension && getConfig('NODE_ENV') === 'development' && <DevTools />}
{this.props.children}
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion client/utils/custom-hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const useModalBehavior = (hideOverlay) => {

// Return values
const setRef = (r) => { ref.current = r; };
const [visible, setVisible] = useState(true);
const [visible, setVisible] = useState(false);
const trigger = () => setVisible(!visible);

const hide = () => setVisible(false);
Expand Down