-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add <Console /> to Mobile Views #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ghalestrilo
merged 13 commits into
processing:develop
from
ghalestrilo:feature/error-output
Jul 21, 2020
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c44e60e
:construction: remove sidebar (temp)
ghalestrilo 18e945c
:construction: Improve Footer, Emplace Console component
ghalestrilo 9529542
:construction: update children prop type
ghalestrilo 8e137d0
:construction: Add Console to Preview Screen
ghalestrilo dd1141b
:construction: connect <Console />
ghalestrilo 0c0fcee
:broom: remove console props from MobilePreview
ghalestrilo b55bec1
:recycle: use connected <Console /> on IDEView
ghalestrilo b2ba22a
:ok_hand: revert hide sidebar
ghalestrilo dd15f80
:broom: remove FIXME
ghalestrilo 2e07990
:ok_hand: refactor <Footer />
ghalestrilo c942753
:ok_hand: remove <Console /> from before
ghalestrilo a1accc1
Merge branch 'develop' into feature/error-output
catarak 8f60b35
Merge branch 'feature/error-output' of https://github.com/ghalestrilo…
ghalestrilo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,42 @@ | ||
import React from 'react'; | ||
import styled from 'styled-components'; | ||
import PropTypes from 'prop-types'; | ||
import { prop, remSize } from '../../theme'; | ||
|
||
|
||
const background = prop('MobilePanel.default.background'); | ||
const textColor = prop('primaryTextColor'); | ||
|
||
const Footer = styled.div` | ||
const FooterWrapper = styled.div` | ||
position: fixed; | ||
width: 100%; | ||
bottom: 0; | ||
`; | ||
|
||
const FooterContent = styled.div` | ||
background: ${background}; | ||
color: ${textColor}; | ||
padding: ${remSize(12)}; | ||
padding-left: ${remSize(32)}; | ||
z-index: 1; | ||
|
||
bottom: 0; | ||
`; | ||
|
||
const Footer = ({ before, children }) => ( | ||
<FooterWrapper> | ||
{before} | ||
<FooterContent> | ||
{children} | ||
</FooterContent> | ||
</FooterWrapper> | ||
); | ||
|
||
Footer.propTypes = { | ||
before: PropTypes.element, | ||
children: PropTypes.oneOfType([PropTypes.element, PropTypes.arrayOf(PropTypes.element)]), | ||
}; | ||
|
||
Footer.defaultProps = { | ||
before: <></>, | ||
children: <></> | ||
}; | ||
|
||
export default Footer; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.