Skip to content

[#1500] Update sketch media file duplication code #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2020
Merged

[#1500] Update sketch media file duplication code #1501

merged 1 commit into from
Jul 16, 2020

Conversation

catarak
Copy link
Member

@catarak catarak commented Jul 16, 2020

  • Sketch duplication code now checks for AWS endpoint via environment
    variable, rather than hard-coded string
  • Fixes aws.controller#getObjectKey, which was incorrectly generating
    file keys

Fixes #1500

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak
[#1500] Update sketch media file duplication code
cc6d868 
- Sketch duplication code now checks for AWS endpoint via environment
  variable, rather than hard-coded string
- Fixes `aws.controller#getObjectKey`, which was incorrectly generating
  file keys
@catarak catarak merged commit b83824d into develop Jul 16, 2020
@catarak catarak deleted the bug/duplicate-sketch-media-files branch July 20, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When duplicating a sketch, media files are not copied
1 participant
@catarak