Skip to content

Webpack config in dev and prod include copywebpack for static transla… #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Webpack config in dev and prod include copywebpack for static transla… #1491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78f87b6
Webpack config in dev and prod include copywebpack for static transla…
oruburos Jul 10, 2020
348056e
Webpack config in dev and prod include copywebpack for static transla…
oruburos Jul 10, 2020
c31a65a
Webpack config in dev and prod include copywebpack for static transla…
oruburos Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/i18n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const fallbackLng = ['en-US'];
const availableLanguages = ['en-US', 'es-419'];

const options = {
loadPath: '/translations/{{lng}}/translations.json',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should stay as '/translations/{{lng}}/translations.json', but the static file config in server/server.js needs to change...

loadPath: 'locales/{{lng}}/translations.json',
requestOptions: { // used for fetch, can also be a function (payload) => ({ method: 'GET' })
mode: 'no-cors'
},
Expand Down
Loading