Skip to content

Refactored getTitle and isUserOwner #1458 #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2020

Conversation

saijatin28
Copy link
Contributor

@saijatin28 saijatin28 commented Jun 19, 2020

#1458
Hello @catarak , I have refactored the following:

Behavior

  1. move method getTitle to pure ext. function receiving props obj
  2. move method isUserOwner to pure ext. function receiving props obj

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@ghalestrilo
Copy link
Collaborator

Nice job, Sai! I suggest moving both methods out of the IDEView class, to avoid using this..

@saijatin28
Copy link
Contributor Author

Hey @ghalestrilo , I've moved them out of the class. You can take a look now and please let me know if I should make more changes :)

@ghalestrilo
Copy link
Collaborator

Good job! Looks good for me :)
Let's hear from @catarak

@saijatin28 saijatin28 requested a review from catarak June 29, 2020 20:33
@catarak
Copy link
Member

catarak commented Jul 1, 2020

thank you!

@catarak catarak merged commit 3ce4973 into processing:develop Jul 1, 2020
@saijatin28
Copy link
Contributor Author

thank you!

It's my pleasure Cassie!

@saijatin28 saijatin28 deleted the refactor-IDEView.jsx branch July 1, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants