Skip to content

add socials buttons for sign up view (fixes issue #1402) #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hmaddisb
Copy link

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented May 18, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@catarak catarak closed this May 26, 2020
@catarak catarak reopened this May 26, 2020
@catarak catarak changed the base branch from master to develop May 28, 2020 17:42
@catarak
Copy link
Member

catarak commented May 28, 2020

Thanks for working on this ✨ Unfortunately due to #1244 being merged in, which adds a SocialAuthButton component, I think it makes sense to close this PR and open a new one.

@catarak catarak closed this May 28, 2020
@catarak catarak reopened this May 28, 2020
@catarak catarak closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants