Skip to content

Added Shortcut Toggle Console #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2020
Merged

Added Shortcut Toggle Console #1287

merged 2 commits into from
Apr 15, 2020

Conversation

shakti97
Copy link
Contributor

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Fixes #1286

nik72619c
nik72619c suggested changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@nik72619c nik72619c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shakti97, please add this shortcut under the keyboard shortcuts list modal.

@shakti97 shakti97 force-pushed the shortcut-toggle-console branch from d312278 to 0f8b489 Compare April 10, 2020 06:34
@catarak
Copy link
Member

catarak commented Apr 15, 2020

Working great for me. Tested on Mac and Windows. Thank you!

@catarak catarak merged commit 46a8d60 into processing:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik72619c nik72619c nik72619c requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcut for Toggle Console Window
3 participants
@shakti97 @catarak @nik72619c