Fix hover effect on Log in and Sign up nav items

[shanrauf]

I have verified that this pull request:

• has no linting errors (npm run lint)
• is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
• is descriptively named and links to an issue number: Applies fixes from #908 to "Log in" and "Sign up"

[catarak]

thanks for working on this. the hover color is fixed, however, it appears the spacing is a little off:

there's more space between "log in" and "or" than "sign up" and "or"

[shanrauf]

Apologies for the weird commit history, had trouble with Git... The unequal spacing was caused by a margin that was originally placed on all nav items seemingly to make the dropdowns and spacing look nicer. However, since Log in and Sign up are a bit different from the left nav bar, I just deleted the margin placed on all nav items, and added a margin to the dropdown triangles (which will only affect the necessary nav items).

Please let me know if there are any other issues.

[shanrauf]

My new commit doesn't weirdly add a button in the Link element anymore. The hover effect I added to all nav__item-headers is a bit redundant because right above it there is something similar for the left nav, but I don't see any other option. I also removed the nav__item class on the right nav li elements, because if you keep that class, then there is the same problem from #908 where the hover effect is applied but the link is not clickable yet. Please let me know if you want anything changed!

[catarak]

there's something funky happening with the git history on this branch...

[shanrauf]

Apologies once again... Everything should be fixed, so please let me know if anything else is wrong. I appreciate you dealing with this inefficiency, I'm learning a lot...

[catarak]

@shanrauf no worries!

[catarak]

this is working great for me. thanks for working on this!