Error not handled correctly in server/controllers/user.controller.js

[BrawlerXull]

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

Error is not handles correctly

Expected Behavior

Should be handles correctly

Steps to reproduce

Steps:

Snippet:

// Paste your code here :)
// This is what i propose 
// Please let me know if here is a better way to solve this
export function findUserByUsername(username, cb) {
  User.findByUsername(username, (err, user) => {
    if (err) {
      console.error("Error finding user:", err);
      cb(null); 
    } else {
      cb(user); 
    }
  });
}

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[BrawlerXull]

[BrawlerXull]

Or we can return a promise?

[lindapaiste]

TBH I wonder if we even need this findUserByUsername function? We could update the one place it’s used, in the aws.controller, to call User.findByUsername directly.

[BrawlerXull]

@lindapaiste i opened the issue but someone else have sent pr I want to solve this

[BrawlerXull]

@lindapaiste also please let me know if there is any slack channel to connect with the org members

[BrawlerXull]

TBH I wonder if we even need this findUserByUsername function? We could update the one place it’s used, in the aws.controller, to call User.findByUsername directly.

I'll look into it