Friendly error links have poor color contrast

[stampyzfanz]

Details about the bug:

• Web browser and version: Firefox 102.0.1
• Operating System: Windows 10
• Steps to reproduce this:
  https://editor.p5js.org/stampyzfanz/sketches/flp7cojOM
  
  The problem is inline CSS that changes the colour of FES links without taking into account the theme that is used.

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[Brady-Edwards]

Hi there, if someone isn't already working on this, I'd like to have a crack! This would also be my first open source contribution :).

[stampyzfanz]

I am not aware of anyone working on it and feel free to let me know if there's anything I can do to help.

Thanks for your interest :)

[Brady-Edwards]

I've got a working fix, can a maintainer give me the green light to open a PR? Thanks.

[raclim]

Hi @Brady-Edwards, super excited to see your work! :) Please feel free to go through with the PR, or let me know if there's anything else you need beforehand!

[devtarun]

Hello. is this still open?

[ayushbhaimehta]

Hi there. If this haven't been resolved yet then I would love to do so. Also can somebody point me where can I get slack or discord link where there is more discussion on issues.
Thank you

[raclim]

Hi @devtarun and @ayushbhaimehta! Yes, this is still currently open, but I think @Brady-Edwards had some work done on this earlier. However, please feel free to add to this issue!

This is the invite URL for the p5.js discord. :)

[Brady-Edwards]

Hi there, I had completely forgotten about this (got carried away with life)! I had already pin-pointed the issue and a fix for it but never got around to issuing a pull request. However, I'm more than happy for someone else to issue the pull request for this instead :). Either way, I'll quickly detail what I found to cause the issue here:

In this snippet here, the color and fill lines are getting overridden with some external css (not sure what's the cause for the overwrite, but it doesn't seem to be from a css stylesheet in the repository). To prevent these from being overridden, the !important tag can be used, which seemed to fix the bug for me. I'm sure there's a better fix out there, but this is all I could find from the time I spent looking at this.

[ayushbhaimehta]

@raclim I pretty much agree with brady. The CSS seemed to be overridden by 2-3 external modules of CSS (one is definitely from main but still can't figure out the other ones).