Skip to content

Upgrade dependencies to the latest stable angular.js #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018

Conversation

dkokic
Copy link

@dkokic dkokic commented May 6, 2018

No description provided.

Copy link
Member

@phra phra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phra
Copy link
Member

phra commented May 23, 2018

@dkokic can you confirm that the project will work without problem w/ angular 1.6 ?

@dkokic dkokic force-pushed the fix/upgrade-angular-dependencies branch from c1b4649 to 72a1c34 Compare May 23, 2018 19:34
@dkokic
Copy link
Author

dkokic commented May 23, 2018

@phra I use angular.js 1.7 at my work projects and have just updated the PR.

Copy link
Member

@phra phra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase and solve the conflicts? thanks.

@dkokic dkokic force-pushed the fix/upgrade-angular-dependencies branch from 72a1c34 to 9a0a0f8 Compare May 24, 2018 16:13
@dkokic
Copy link
Author

dkokic commented May 24, 2018 via email

@phra phra merged commit 9ba38bc into preboot:master May 24, 2018
@phra
Copy link
Member

phra commented May 24, 2018

@dkokic thanks for the contributions! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants