stop using componentWillUpdate

[alexcjohnson]

Currently we update the plot in componentWillUpdate - it works, but it's a little weird and this method is deprecated.

• Put the conditionals preventing updates into shouldComponentUpdate?
• Move the update itself to componentDidUpdate
• The chain of events in componentDidMount (initial draw) and the update code are a little different, but there may be some opportunity to DRY this up - at least, the Plotly.newPlot in the initial draw can safely be turned into Plotly.react.

[dmt0]

@alexcjohnson if we switch to using Plotly.react, would we need to bump plotly.js peer dependency which is currently set as: "plotly.js": ">1.34.0"

[alexcjohnson]

No, v1.34.0 is in fact the version that introduced Plotly.react... which makes sense since the fallback code for missing Plotly.react has already been removed.

[nicolaskruchten]

Yes merging the logic into DidUpdate and getting rid of newPlot seems like a winner to me