Skip to content

Full Mapbox support #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Full Mapbox support #961

wants to merge 7 commits into from

Conversation

nicolaskruchten
Copy link
Contributor

No description provided.

@VeraZab
Copy link
Contributor

VeraZab commented Sep 17, 2019

in the dev app, could we remove the mapbox access token please? i often end up losing that accessToken file

@nicolaskruchten
Copy link
Contributor Author

Well as of this PR you can set the token to an empty string :)

@nicolaskruchten
Copy link
Contributor Author

Meaning you can just do cp accessTokens.js.tpl accessTokens.js and it'll "just work" without the Mapbox-service features

@VeraZab
Copy link
Contributor

VeraZab commented Sep 17, 2019

As discussed on slack:

  • for the scattermapbox trace, looks like changing the base map tile source, when layers have already been added, does not keep the layers. Even deleting and adding back the layers does not work.
  • also, i seem to have gotten a few times into a state when deleting my trace (Ex choropleth tile map) and adding another one (ex. density tile map). And then adding lat/lon/z, did not do anything to the map. no trace was drawn. sometimes i get into that state, sometimes i don't..

@@ -14,7 +14,7 @@ import 'brace/theme/textmate';
// https://github.com/plotly/react-chart-editor#mapbox-access-tokens
import ACCESS_TOKENS from '../accessTokens';

import {customConfigTest} from '../src/__stories__';
// import {customConfigTest} from '../src/__stories__';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it in ../src/__stories, because when i had it in dev/App.js the imports that file has were causing issues with the percy tests. I guess this could go into it's separate file. But yes we can just comment out. Not exactly sure though what's causing the issue.. maybe that we reimport plotly.js in that storybook file, from a different place..

@VeraZab
Copy link
Contributor

VeraZab commented Sep 17, 2019

code looks good to me otherwise 💃

@VeraZab
Copy link
Contributor

VeraZab commented Sep 17, 2019

squash commits before merging?

@nicolaskruchten
Copy link
Contributor Author

yes, for sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants