-
-
Notifications
You must be signed in to change notification settings - Fork 112
Full Mapbox support #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Mapbox support #961
Conversation
7782460
to
62ff507
Compare
in the dev app, could we remove the mapbox access token please? i often end up losing that accessToken file |
Well as of this PR you can set the token to an empty string :) |
Meaning you can just do |
As discussed on slack:
|
@@ -14,7 +14,7 @@ import 'brace/theme/textmate'; | |||
// https://github.com/plotly/react-chart-editor#mapbox-access-tokens | |||
import ACCESS_TOKENS from '../accessTokens'; | |||
|
|||
import {customConfigTest} from '../src/__stories__'; | |||
// import {customConfigTest} from '../src/__stories__'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put it in ../src/__stories
, because when i had it in dev/App.js
the imports that file has were causing issues with the percy tests. I guess this could go into it's separate file. But yes we can just comment out. Not exactly sure though what's causing the issue.. maybe that we reimport plotly.js in that storybook file, from a different place..
code looks good to me otherwise 💃 |
squash commits before merging? |
yes, for sure :) |
No description provided.