column names to meta #936
Merged
column names to meta #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskruchten
force-pushed
the
metaname
branch
2 times, most recently
from
e4c3f8e to
8046e9b
Compare
nicolaskruchten
force-pushed
the
metaname
branch
from
8046e9b to
31c5919
Compare
|
@VeraZab ready for review! |
VeraZab
reviewed
Jun 17, 2019
| @@ -94,6 +95,14 @@ export class UnconnectedDataSelector extends Component { | |||
| fromSrc: this.context.srcConverters ? this.context.srcConverters.fromSrc : null, | |||
| }); | |||
|
|
|||
| if (this.props.container.type) { | |||
There was a problem hiding this comment.
well, actually, it's possible not to provide trace.type in data, then plotly.js defaults to scatter..
maybe we should encode this in the editor.. this will only be potentially a problem for figures created with an api, where the person did not specify trace.type
There was a problem hiding this comment.
oh actually nevermind, I think we'd be handling that here: https://github.com/plotly/react-chart-editor/blob/master/src/lib/customTraceType.js#L9
|
looks good to me 💃 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.