Funnel support #934
Funnel support #934
Conversation
| "data": [ | ||
| { | ||
| "type": "funnel", | ||
| "y": ["Lead", "Pipeline", "Proposal", "Negotiation", "Closed (Won)"], |
There was a problem hiding this comment.
just a general, more plot.js type question. Why are the axes for funnel (x/y) and funnelarea (labels/values), why couldn't they both have been named (labels/values) ? I feel like that would have been easier understand for a business type chart.
There was a problem hiding this comment.
yeah this is because funnel is based on bar and is on cartesian axes, but funnelarea is based on pie and has no axes or orientation.
| ['pie', 'table', 'sunburst', 'sankey', 'parcoords', 'parcats'].includes(d.type) | ||
| ['pie', 'table', 'sunburst', 'sankey', 'parcoords', 'parcats', 'funnelarea'].includes( | ||
| d.type | ||
| ) |
There was a problem hiding this comment.
it's nice that we can make subplots with funnelarea, but the legends will overlap, unless there's a control i've missed for that?
There was a problem hiding this comment.
the legend is merged, not overlapping, just like with a multi-pie scenario.
| } else if (traceType === 'sunburst') { | ||
| this.name = _('Sunburst Segments'); | ||
| } else if (['funnelarea', 'pie', 'sunburst'].includes(traceType)) { | ||
| this.name = _('Segments'); |
| line: {color: COLORS.blueTeal}, | ||
| fillcolor: 'rgba(23, 190, 207, 0.5)', | ||
| }, | ||
| orientation: 'v', |
There was a problem hiding this comment.
well, I was asked for those colors previously.. but if we don't need them anymore ok..
There was a problem hiding this comment.
yeah I don't think it makes sense personally.
|
well, overall, this looks good to me 💃 |
Outstanding: