Skip to content

correct iteration over children #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2018
Merged

correct iteration over children #240

merged 2 commits into from
Jan 15, 2018

Conversation

nicolaskruchten
Copy link
Contributor

Fix for #228 ... uses React.Children.map to iterate over children without assuming it's an array.

/cc @VeraZab for future reference https://mxstbr.blog/2017/02/react-children-deepdive/

bpostlethwaite
bpostlethwaite approved these changes Jan 15, 2018
View reviewed changes
Copy link
Member

@bpostlethwaite bpostlethwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@nicolaskruchten nicolaskruchten merged commit ec37c48 into master Jan 15, 2018
@nicolaskruchten nicolaskruchten deleted the fix_children branch January 15, 2018 19:43
@VeraZab
Copy link
Contributor

VeraZab commented Jan 16, 2018

thanks @nicolaskruchten !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpostlethwaite bpostlethwaite bpostlethwaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolaskruchten @VeraZab @bpostlethwaite