Skip to content

Trace name fix #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 28, 2017
Merged

Trace name fix #191

merged 5 commits into from
Dec 28, 2017

Conversation

VeraZab
Copy link
Contributor

@VeraZab VeraZab commented Dec 28, 2017

fixes: #174

@VeraZab
Copy link
Contributor Author

VeraZab commented Dec 28, 2017

alright @bpostlethwaite change of plan :) will make small prs that address the official release milestone as priority.

So here, just a few explanations, when sending plotly.js a 'scatter' type without a mode, plotly.js will automatically assume it's a marker+lines mode, that's why in the trace recognition function I added 'marker+lines' to the 'lines' trace type

Yup, let me know if for any other clarifications, thanks!

bpostlethwaite
bpostlethwaite requested changes Dec 28, 2017
View reviewed changes
Copy link
Member

@bpostlethwaite bpostlethwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a quick unit test on this behaviour in TraceSelector-test?

src/lib/customTraceType.js Outdated
@@ -0,0 +1,32 @@
export function plotlyToCustom(trace) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotlyToCustomTrace and customTraceToPlotly? Not a big deal but it isn't apparent from the function name what it is actually doing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(could be custom axes or custom sandwiches :) )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or even more explicit plotlyTraceToCustomTrace and customTraceToPlotlyTrace ? This ought to appeal to someone who likes typing MultiTextEditor instead of TextEditor ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, alright!

@VeraZab
Copy link
Contributor Author

VeraZab commented Dec 28, 2017

💃 ?

@bpostlethwaite
Copy link
Member

💃

@VeraZab VeraZab merged commit f3ac4cc into master Dec 28, 2017
@VeraZab VeraZab deleted the trace-name-fix branch December 28, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpostlethwaite bpostlethwaite bpostlethwaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editor initializes trace as "line" though chart type selector says "scatter"
2 participants
@VeraZab @bpostlethwaite