Skip to content

fix issue #196 #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2021
Merged

fix issue #196 #221

merged 2 commits into from
Jul 29, 2021

Conversation

gilbertogalvis
Copy link
Contributor

No description provided.

@VolKa79
Copy link

VolKa79 commented Jul 29, 2021

It works correctly now, but have question...

Instead of ...
if ( ...
strcmpi(obj.data{d}.type, 'scatter') || ...
strcmpi(obj.data{d}.type, 'bar') ...
)
why not to do in one line like

if ( strcmpi(obj.data{d}.type, 'scatter') || strcmpi(obj.data{d}.type, 'bar' ))

@gilbertogalvis
Copy link
Contributor Author

that is because it is possible in the near futere we need to add more conditionals like those.

@gilbertogalvis gilbertogalvis merged commit a460022 into master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants