check OpenURL before launching browser in offline mode #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is necessary otherwise when parameters 'offline':true and 'open':false are passed to fig2plotly, plotly still tries to open up the browser.
|
Thanks for the fix @imatlab-helper |
|
Cheers! Thanks for the fast turnaround and for working on such an immensely valuable tool. The impact on the educational and scientific communities is tremendous. Please keep it up! |
a6
pushed a commit
to a6/MATLAB-Online
that referenced
this pull request
Mar 7, 2017
Any chance we can get the version number updated in response to the PR plotly#116 merge? This would help dependent applications ensure they have the right version.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117. This check is necessary otherwise when parameters 'offline':true and 'open':false are passed to fig2plotly, plotly still tries to open up the browser.