Better pip install error msg for county choropleth #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test are passing now - ready for a review |
cldougl
reviewed
Apr 2, 2018
| @@ -563,11 +563,15 @@ def create_choropleth(fips, values, scope=['usa'], binning_endpoints=None, | |||
| if not gp or not shapefile or not shapely: | |||
| raise ImportError( | |||
| "geopandas, pyshp and shapely must be installed for this figure " | |||
| "factory.\n\nRun the following commands in the terminal to " | |||
| "ensure that the correct versions of the modules are installed:\n" | |||
| "factory.\n\nIf you are using OS X run the following commands in " | |||
There was a problem hiding this comment.
this is os x and linux right?
Maybe this could be streamlined by saying:
Run the following commands to install the correct versions of the following modules:
If you are using Windows, follow this post to properly install geopandas and dependencies: http://geoffboeing.com/2014/09/using-geopandas-windows/
There was a problem hiding this comment.
I like the wording: the set of operating systems are fully covered.
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cldougl