added histogram to facet_grid #776

Kully · 2017-06-20T16:40:13Z

No description provided.

Kully · 2017-06-20T16:42:43Z

Kully · 2017-06-20T17:20:26Z

@chriddyp @cldougl
would like a review when tests pass

cldougl · 2017-06-20T18:00:53Z

CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).

+## [Unreleased]
+### Added
+- `.create_facet_grid` now supports histogram traces.


maybe figure_factory.create_facet_grid just to be super clear

cldougl · 2017-06-20T18:03:25Z

just tried putting hist in one of the docstring examples and it's rendered a bit weird and needs to be autoscaled:

import plotly.plotly as py
import plotly.figure_factory as ff  

import pandas as pd
mpg = pd.read_table('https://raw.githubusercontent.com/plotly/datasets/master/mpg_2017.txt')

fig = ff.create_facet_grid(mpg, x='displ', y='cty', facet_col='cyl', trace_type='histogram')
py.iplot(fig, filename='facet_grid_mpg_one_way_facet')

cldougl · 2017-06-20T18:10:58Z

plotly/figure_factory/_facet_grid.py

        )

+    temp_trace = 'scatter' if (trace_type == 'histogram') else trace_type


since this renders the trace as scatter first, the histogram attributes can't be passed. For example:

tips = pd.read_csv('https://raw.githubusercontent.com/plotly/datasets/master/tips.csv') fig = ff.create_facet_grid( tips, x='total_bill', y='tip', trace_type='histogram', histfunc='sum', facet_row='sex', facet_col='smoker' ) py.iplot(fig, filename='facet_grid_tips_sequential_colors')

fails with:

Kully · 2017-06-20T20:30:14Z

Note: going to add lines to histogram for aesthetics

Kully · 2017-06-23T22:49:28Z

@cldougl tests finally passed. good to merge?

cldougl · 2017-06-26T16:35:12Z

I'll take another look this afternoon @Kully
can you fix the changelog conflicts?

chriddyp · 2017-06-26T17:17:28Z

plotly/figure_factory/_facet_grid.py

@@ -25,6 +25,7 @@
 THRES_FOR_FLIPPED_FACET_TITLES = 10
 GRID_WIDTH = 1

+VALID_TRACE_TYPES = ['scatter', 'scattergl', 'histogram']


technically other types too though, right? I think that box, histogram2d, and bar might work now

I remember not liking the look of box or bar - it was very squashed up, but perhaps it was the dataset

chriddyp · 2017-06-26T17:19:23Z

plotly/figure_factory/_facet_grid.py

@@ -189,18 +190,22 @@ def _facet_grid_color_categorical(df, x, y, facet_row, facet_col, color_name,
    if not facet_row and not facet_col:
        color_groups = list(df.groupby(color_name))
        for group in color_groups:
-            trace = graph_objs.Scatter(
+            trace = dict(
                x=group[1][x],
                y=group[1][y],


I'm having a hard time understanding what happens when the histogram mode sets both x and y here. Shouldn't only one of them be set?

Or is just the other variable ignored?

Oh, or the user just doesn't supply the y variable when setting it? Like

FF.facet_grid(df, x='categorial-column', facet_col='another-column', trace_type='histogram')

You found an oversight in my design.

Originally this was meant for just scatter, so I was forcing x and y. I'm going to try not forcing x and y and putting df[x] and df[y] in the trace dictionary depending on what the user provides

Kully · 2017-06-27T01:53:00Z

@chriddyp We got some nice variety going:

Kully · 2017-06-29T17:33:29Z

@cldougl Can you give this one quick review today? I'm trying to get it merged today and the pip package updated so I can finish documentation by the end of the week.

Thank you 😄

cldougl · 2017-06-29T17:53:09Z

@Kully is it possible to change the color of the markers?
Like:

import plotly.plotly as py
import plotly.figure_factory as ff

import pandas as pd

mpg = pd.read_table('https://raw.githubusercontent.com/plotly/datasets/master/mpg_2017.txt')

fig = ff.create_facet_grid(
    mpg,
    x='displ',
    y='cty',
    facet_row='drv',
    facet_col='cyl',
    marker=dict(color='rgba(255, 182, 193, .9)')
)
py.iplot(fig, filename='facet_grid_mpg_two_way_facet')

cldougl · 2017-06-29T18:03:11Z

plotly/figure_factory/_facet_grid.py

+
+    fig = ff.create_facet_grid(
+        mtcars,
+        x='wt',


shouldn't this example only have an x or a y?

cldougl · 2017-06-29T18:06:50Z

plotly/figure_factory/_facet_grid.py

                type=trace_type,
                marker=dict(
                    color=marker_color,
-                    **kwargs_marker
+                    line=kwargs_marker['line'],
+                    #opacity=kwargs_marker['opacity'],


should this be commented out?

cldougl · 2017-06-29T18:10:22Z

plotly/figure_factory/_facet_grid.py

@@ -25,6 +25,7 @@
 THRES_FOR_FLIPPED_FACET_TITLES = 10
 GRID_WIDTH = 1

+VALID_TRACE_TYPES = ['scatter', 'scattergl', 'histogram', 'bar', 'box']


are we planning on adding histogram2d as well (#776 (review)) ?

and histogram2dcontour

Since marker is not a valid key in facet grid, I vote that these trace types get moved into another PR/Issue. It would require a large reworking of the code, so I think we should move it to another issue so we can get this merged so the documentation can go up this week.

I'm ok w/ doing those in a different pr

cldougl · 2017-06-29T18:20:17Z

looks like the histogram labels will overlap due to how the ticks are labeled at the bin edges. Do you think there's something stylistically we could do to avoid this such as increasing the gap between when the histogram trace is used?

chriddyp · 2017-06-29T19:01:27Z

looks good to me! 💃 from me once @cldougl 's comments are addressed

Kully · 2017-06-29T19:19:03Z

looks like the histogram labels will overlap due to how the ticks are labeled at the bin edges. Do you think there's something stylistically we could do to avoid this such as increasing the gap between when the histogram trace is used?

Yeah, I think that would be a good idea

cldougl · 2017-06-30T19:42:48Z

💃 good for me too
(lmk if you want me to fix the changelog conflict @Kully )

Kully · 2017-06-30T19:47:56Z

💃 good for me too
(lmk if you want me to fix the changelog conflict @Kully )

just did

added histogram to facet_grid

ccc92da

changelog

bda26e1

cldougl reviewed Jun 20, 2017

View reviewed changes

Kully mentioned this pull request Jun 20, 2017

facet python doc plotly/documentation#773

Merged

chelse's comments

3be914a

Kully added 2 commits June 21, 2017 12:07

Merge branch 'master' into add-hist-to-facet

236e9a7

added lines to histograms - like in scatter

37d576d

chriddyp reviewed Jun 26, 2017

View reviewed changes

Kully added 6 commits June 26, 2017 13:20

Merge branch 'master' into add-hist-to-facet

1e355b1

fixed scales oversight

180e0b7

add several more trace_types

483b487

foxed ggplot2 line bug

5273f2d

fixed tests

af965d0

the merge

5e0acc2

string doc and CHANGELOG update

788dcf9

cldougl reviewed Jun 29, 2017

View reviewed changes

Kully added 4 commits June 29, 2017 15:52

patched color - works now

e532d3e

fix spacing for histogram

8cd0de1

null

1ff4b5f

trace types

c99c0e7

Merge branch 'master' into add-hist-to-facet

2e7fecb

date to changelog

1b0e434

Kully merged commit 17b27dd into master Jul 1, 2017

Kully deleted the add-hist-to-facet branch July 1, 2017 11:19

		)

		temp_trace = 'scatter' if (trace_type == 'histogram') else trace_type

Uh oh!

added histogram to facet_grid #776

added histogram to facet_grid #776

Uh oh!

Conversation

Kully commented Jun 20, 2017

Uh oh!

Kully commented Jun 20, 2017

Uh oh!

Kully commented Jun 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cldougl commented Jun 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kully commented Jun 20, 2017

Uh oh!

Kully commented Jun 23, 2017

Uh oh!

cldougl commented Jun 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kully commented Jun 27, 2017

Uh oh!

Kully commented Jun 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cldougl commented Jun 29, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cldougl commented Jun 29, 2017

Uh oh!

chriddyp commented Jun 29, 2017

Uh oh!

Kully commented Jun 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cldougl commented Jun 30, 2017

Uh oh!

Kully commented Jun 30, 2017

Uh oh!

Uh oh!

Kully commented Jun 20, 2017 •

edited

Loading

Kully commented Jun 29, 2017 •

edited

Loading

Kully commented Jun 29, 2017 •

edited

Loading