Validate signin #668
Validate signin #668
Conversation
theengineear
force-pushed
the
validate-signin
branch
from
e44772a to
279a648
Compare
| @@ -24,11 +24,9 @@ | |||
| import six.moves | |||
| from requests.compat import json as _json | |||
|
|
|||
| from plotly import exceptions, tools, utils, files | |||
| from plotly import exceptions, files, session, tools, utils | |||
There was a problem hiding this comment.
I'm just curious, why did you switch up the order like this? Is it because tools is moving into a different location for 2.0.0. and therefore its priority is being hierarchically diminished? (I don't know the proper jargon for what I'm describing...)
There was a problem hiding this comment.
looks like it's just alphabetical 😎
| un = 'anyone' | ||
| ak = 'something' | ||
| # TODO, add this! | ||
| # si = ['this', 'and-this'] |
There was a problem hiding this comment.
What does this TODO mean exactly? I'm guessing si means something here?
There was a problem hiding this comment.
That's just old code. I just needed to add it to the TestCase class. I think it's for stream ids probably? I'm not going to futz with it in this PR though.
All good, just a few questions I threw in there. 💃 |
|
good to me! |
|
Uggs. GH/CI stuff has been weird the last day or so. These tests all passed in the most recent build: https://circleci.com/gh/plotly/plotly.py/1883 Gonna merge! |
Simply raises a
PlotlyErrorif we can't hit/v2/users/currentsuccessfully given the session credentials.I decided to let the session creds/config get set and not revert on fail. It felt simpler to me and I didn't know why it would be beneficial to do anything otherwise.