Skip to content

add print_grid param to create_violin #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2016
Merged

add print_grid param to create_violin #557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f28947
add print_grid param to create_violin
Kully Aug 29, 2016
8626d6d
implicitly turn off print_grid display for Violin only
Kully Sep 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions plotly/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2731,7 +2731,7 @@ def _violin_no_colorscale(data, data_header, group_header, colors,
fig = make_subplots(rows=1, cols=L,
shared_yaxes=True,
horizontal_spacing=0.025,
print_grid=True)
print_grid=False)
color_index = 0
for k, gr in enumerate(group_name):
vals = np.asarray(gb.get_group(gr)[data_header], np.float)
Expand Down Expand Up @@ -2769,7 +2769,8 @@ def _violin_no_colorscale(data, data_header, group_header, colors,

@staticmethod
def _violin_colorscale(data, data_header, group_header, colors,
use_colorscale, group_stats, height, width, title):
use_colorscale, group_stats, height, width,
title):
"""
Refer to FigureFactory.create_violin() for docstring.

Expand Down Expand Up @@ -2799,7 +2800,7 @@ def _violin_colorscale(data, data_header, group_header, colors,
fig = make_subplots(rows=1, cols=L,
shared_yaxes=True,
horizontal_spacing=0.025,
print_grid=True)
print_grid=False)

# prepare low and high color for colorscale
lowcolor = FigureFactory._color_parser(
Expand Down Expand Up @@ -2900,7 +2901,7 @@ def _violin_dict(data, data_header, group_header, colors, use_colorscale,
fig = make_subplots(rows=1, cols=L,
shared_yaxes=True,
horizontal_spacing=0.025,
print_grid=True)
print_grid=False)

for k, gr in enumerate(group_name):
vals = np.asarray(gb.get_group(gr)[data_header], np.float)
Expand Down