Skip to content

Bump python versions in CI and add python 3.13 #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 10, 2025
Merged

Bump python versions in CI and add python 3.13 #5073

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f2d08bc
bump python versions in ci and add python 3.13
emilykl Mar 7, 2025
40c1004
build-doc won't run on python 3.12, rip
emilykl Mar 7, 2025
f96c25f
bump python version from 3.9 to 3.12 for percy tests (will this work?)
emilykl Mar 7, 2025
02a23ff
remove scipy pin
emilykl Mar 7, 2025
e8cb1f0
try 3.11 for percy tests
emilykl Mar 7, 2025
533f5f7
use python 3.9 for build-doc
emilykl Mar 10, 2025
3e0a46c
bump pandas 1 version for Percy tests
emilykl Mar 10, 2025
18f8444
re-pin scipy version
emilykl Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ executors:
parameters:
python_version:
description: "python version"
default: "3.10"
default: "3.12"
type: string
docker:
- image: cimg/python:<<parameters.python_version>>-browsers
Expand Down Expand Up @@ -120,7 +120,7 @@ commands:
jobs:
check-code-formatting:
docker:
- image: cimg/python:3.7
- image: cimg/python:3.12

steps:
- checkout
Expand All @@ -139,7 +139,7 @@ jobs:
test_core_py:
parameters:
python_version:
default: "3.10"
default: "3.12"
type: string
executor:
name: docker-container
Expand All @@ -150,7 +150,7 @@ jobs:
test_optional_py:
parameters:
python_version:
default: "3.10"
default: "3.12"
type: string
pandas_version:
default: ""
Expand All @@ -167,9 +167,9 @@ jobs:
numpy_version: <<parameters.numpy_version>>

# Percy
python_39_percy:
python_311_percy:
docker:
- image: cimg/python:3.9-browsers
- image: cimg/python:3.11-browsers
environment:
PERCY_ENABLED: True
PERCY_PROJECT: plotly/plotly.py
Expand Down Expand Up @@ -203,7 +203,6 @@ jobs:
source .venv/bin/activate
mkdir tests/percy/pandas2
mv tests/percy/*.html tests/percy/pandas2/
# 1.1 is the earliest minor with Py3.9 wheels
uv pip install pip
python -m pip install pandas==1.1.5 numpy==1.26.4
python tests/percy/plotly-express.py
Expand All @@ -224,7 +223,7 @@ jobs:

plotlyjs_dev_build:
docker:
- image: cimg/python:3.11-node
- image: cimg/python:3.12-node
environment:
LANG: en_US.UTF-8
resource_class: large
Expand Down Expand Up @@ -263,7 +262,7 @@ jobs:

full_build:
docker:
- image: cimg/python:3.11-node
- image: cimg/python:3.12-node
environment:
LANG: en_US.UTF-8
resource_class: large
Expand Down Expand Up @@ -302,8 +301,8 @@ jobs:
resource_class: xlarge
docker:
# specify the version you desire here
# use `-browsers` prefix for selenium tests, for example, `3.9-browsers`
- image: cimg/python:3.9-browsers
# use `-browsers` prefix for selenium tests, for example, `3.12-browsers`
- image: cimg/python:3.11-browsers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of sphinx that we use doesn't support 3.10 or later. Ideally the docs build would use a more recent Python version than 3.9, but we'd need to also update the sphinx dependency and test it. I think the update would bring some visual changes to the docs. This is a related issue #4085

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roger -- I'll leave as 3.9 for now


steps:
- add_ssh_keys:
Expand Down Expand Up @@ -435,6 +434,7 @@ workflows:
- "3.10"
- "3.11"
- "3.12"
- "3.13"
- test_optional_py:
matrix:
parameters:
Expand All @@ -444,10 +444,11 @@ workflows:
- "3.10"
- "3.11"
- "3.12"
- "3.13"
- test_optional_py:
name: "test_optional_py-3.9_pandas-1.2.4"
python_version: "3.9"
pandas_version: "1.2.4"
numpy_version: "1.26.4"
- python_39_percy
- python_311_percy
- build-doc
2 changes: 1 addition & 1 deletion doc/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jupyter
notebook
pandas==1.4.0
statsmodels==0.14.2
scipy==1.9.1
scipy
patsy==0.5.6
numpy==1.22.4
plotly-geo
Expand Down