Allow for the option of a CDN in offline mode #475
Conversation
|
After latest commit:
|
|
Pinging @briehl, in case you have any extra feedback on the API for the KBase uses... |
| @@ -193,7 +208,7 @@ def iplot(figure_or_data, show_link=True, link_text='Export to plot.ly', | |||
|
|
|||
| plot_html, plotdivid, width, height = _plot_html( | |||
| figure_or_data, show_link, link_text, validate, | |||
| '100%', 525, global_requirejs=True) | |||
| '100%', 525, global_requirejs=__PLOTLY_USE_CDN) | |||
There was a problem hiding this comment.
@yankev : Should not this be opposite? I havent looked at the complete code, but if __PLOTLY_USE_CDN is True, should not global_requirejs=False?
|
I'm pretty sure @tarzzz's comment is right - might want to switch, or change the check for |
| script_inject = ( | ||
| '' | ||
| '<script>' | ||
| # 'if(!window.Plotly) {{' |
There was a problem hiding this comment.
Are these meant to be uncommented?
There was a problem hiding this comment.
There were some persistence and notebook sharing issues from time to time when I left them in. So I just took them out for now.
|
@yankev : Looks good.. |
|
@yankev looks good to me too 💃 |
| '<script>' | ||
| 'requirejs.config({' | ||
| 'paths: { ' | ||
| '\'plotly\': [\'https://cdn.plot.ly/plotly-latest.min\']},' |
There was a problem hiding this comment.
isn't this supposed to be https://cdn.plot.ly/plotly-latest.min.js? Are you missing the ".js"?
@chriddyp First attempt at it. Couldn't get it to work out.
Notes:
<script src ..>for loading plotlyjs.What happens: