First PR for Gantt Charts - Adding Tests Very Soon #460

Kully · 2016-05-16T21:27:17Z

Adding Tests Very Soon

Kully · 2016-05-17T19:58:54Z

theengineear · 2016-05-17T20:14:49Z

Awesome! I'm not gonna have time to take a solid peek at this until later in the week. One quick comment though. It might be cool to have a label for the color scale (about the %task done).

Kully · 2016-05-17T20:21:01Z

Awesome! I'm not gonna have time to take a solid peek at this until later in the week. One quick comment though. It might be cool to have a label for the color scale (about the %task done).

You mean like 'Portland' over top the colorscale bar?

theengineear · 2016-05-17T20:31:00Z

Ah, sorry, totally vague. I mean like:

theengineear · 2016-05-17T20:31:44Z

It's cool if others think this is a bad call, but I wonder if folks who don't know what a gantt chart is would understand what those colors mean immediately.

Kully · 2016-05-17T20:48:42Z

It's cool if others think this is a bad call, but I wonder if folks who don't know what a gantt chart is would understand what those colors mean immediately.

We should just paste the full doc string on the side of the graph.

jackparmer · 2016-05-29T23:06:16Z

It's cool if others think this is a bad call, but I wonder if folks who don't know what a gantt chart is would understand what those colors mean immediately.

Makes sense to me, I didn't get what the color bar was for either. Should we make the color bar and sequential colorscale a kwarg rather than the default? I think the default color meaning on Gantt charts is usually categorical with a qualitative color palette. I'm thinking of this one, for example, http://moderndata.plot.ly/gantt-charts-in-r-using-plotly/. Or the colors simply help the eye differentiate between different tasks. In either case, no need for a color bar.

Kully · 2016-05-30T19:10:42Z

Or the colors simply help the eye differentiate between different tasks. In either case, no need for a color bar.

Okay. Will get cracking on this shortly.

Kully · 2016-05-31T19:53:46Z

@theengineear @jackparmer

I just need to add dictionary compatibility so a user can assign a color to a value in the indexing column.

Kully · 2016-06-02T17:48:05Z

@theengineear @jackparmer

Tests are working.

I want to get a legend working in this Gantt chart as well. @theengineear do you have any ideas on how to do this? I tried appending some stuff to data to just display the legend, but it didn't work.

theengineear · 2016-06-03T03:10:59Z

plotly/tests/test_core/test_tools/test_figure_factory.py

+                                tls.FigureFactory.create_gantt, df,
+                                colors=colors_dict_good)
+
+    def test_gantt_all_args(self):


great test!

theengineear · 2016-06-03T03:16:57Z

I want to get a legend working in this Gantt chart as well.

Can you show me a mock of what you're trying to achieve? It can be incredibly rough, or even just a text description.

jackparmer · 2016-06-03T05:00:46Z

Hey @Kully - You could try using the legendonly attribute for a scatter trace type, then make the scatter the same color as the Gantt rectangle and turn off hover text:

https://plot.ly/python/reference/#scatter-visible

Then you could get optional labels in the legend like "Task 1", "Task 2", that match the color of the Gantt rectangles.

Kully · 2016-06-03T15:55:16Z

Can you show me a mock of what you're trying to achieve? It can be incredibly rough, or even just a text description.

theengineear · 2016-06-03T20:01:20Z

@etpinard or @mdtusz could you give us a pointer on this one?

#460 (comment)

I want to get a legend working in this Gantt chart as well. ...I tried appending some stuff to data to just display the legend, but it didn't work.

It seems like we need to get shapes to show in the legend. (1) possible? (2) is there a workaround that you can think of?

The legendonly seems like it would work, did you get a chance to try that @Kully?

Kully · 2016-06-03T20:04:17Z

The legendonly seems like it would work, did you get a chance to try that @Kully?

I tried it out but didn't have any luck. The legend wasn't showing up but I may have been doing it wrong.

Kully · 2016-06-03T20:05:27Z

It seems like we need to get shapes to show in the legend. (1) possible? (2) is there a workaround that you can think of?

I think it should be possible (as I got the colormap to be visible via an invisible trace). I think I might be missing something with my syntax

Kully · 2016-06-17T17:29:20Z

@theengineear

Kully · 2016-06-17T17:46:34Z

theengineear · 2016-06-17T17:52:54Z

plotly/tests/test_core/test_tools/test_figure_factory.py

+        df = [dict(Task='Job A',
+                   Start='2009-02-01',
+                   Finish='2009-08-30',
+                   Complete='a')]


No big deal (not worth changing here), but if your just using dict, it's typically more common to use the literal notation {}.

theengineear · 2016-06-17T19:08:17Z

Awesome! 💃 after you've added those tests! The other comments are non-blocking.

Kully added 4 commits May 16, 2016 17:10

First PR for Gantt Charts - Adding Tests Very Soon

0eeae61

Added Doc Strings and Tests

fe67a2b

made range(len(tasks)) into a list for Python 3

e228307

Added colorbar visibility on the side of chart

e7a1596

Kully added 4 commits May 31, 2016 10:49

Made Gantt Changes

3035dba

More stuff

675ba7d

updated unlabel_rgb

29dbb44

gantt//update old parsing functions//tests

6671106

Kully added 5 commits May 31, 2016 15:56

Updated schema

7ac7d9b

Updated tests

f165b73

Rewrote tests in core and optional

00f8162

added colors dictionary option

66382e2

Added dictionary compatibility to colors/fixed doc strings

86f61bc

theengineear reviewed Jun 3, 2016
View reviewed changes

REQ to REQUIRED

abff982

trace attempts

e6aa0e4

Kully added 3 commits June 15, 2016 13:18

Merged master into Gantt

3b75d48

Added color_parser functionality in create_gantt

cfa066e

Added legend support for gantt charts and added more tests

ba65217

theengineear reviewed Jun 17, 2016
View reviewed changes

Kully added 10 commits June 17, 2016 16:39

Added dataframe all_args test for gantt//various formatting

9e52ce4

added self.maxDiff=None

ac64ff3

Switch to assertequaldict in test

b28f040

Another one

866f5c9

test 'shapes' in 'layout' only

2142397

just test data

bfbe24c

Redo test

afd45a1

try again

3ac0da4

again

0ab3ad1

Fixed formatting

a7be116

Kully merged commit 36686ad into master Jun 18, 2016

Kully deleted the Gantt branch June 18, 2016 23:38

Uh oh!

First PR for Gantt Charts - Adding Tests Very Soon #460

First PR for Gantt Charts - Adding Tests Very Soon #460

Uh oh!

Conversation

Kully commented May 16, 2016

Uh oh!

Kully commented May 17, 2016

Uh oh!

theengineear commented May 17, 2016

Uh oh!

Kully commented May 17, 2016

Uh oh!

theengineear commented May 17, 2016

Uh oh!

theengineear commented May 17, 2016

Uh oh!

Kully commented May 17, 2016

Uh oh!

jackparmer commented May 29, 2016

Uh oh!

Kully commented May 30, 2016

Uh oh!

Kully commented May 31, 2016

Uh oh!

Kully commented Jun 2, 2016

Uh oh!

theengineear Jun 3, 2016

Choose a reason for hiding this comment

Uh oh!

theengineear commented Jun 3, 2016

Uh oh!

jackparmer commented Jun 3, 2016

Uh oh!

Kully commented Jun 3, 2016

Uh oh!

theengineear commented Jun 3, 2016

Uh oh!

Kully commented Jun 3, 2016

Uh oh!

Kully commented Jun 3, 2016

Uh oh!

Kully commented Jun 17, 2016

Uh oh!

Kully commented Jun 17, 2016

Uh oh!

theengineear Jun 17, 2016

Choose a reason for hiding this comment

Uh oh!

theengineear commented Jun 17, 2016

Uh oh!

Uh oh!