First Push for Trisurf Plots #453

Kully · 2016-05-03T17:44:28Z

This is the PR for create_trisurf() in FigureFactory.

The functionality so far is this: it takes arrays x, y and z (the vertices of the points) which are to be created outside the function. This requires a _import numpy _and from scipy.spatial import Delaunay in the notebook.

It looks pretty cool right now. Like the scatterplotmatrix, you can enter a Plotly colorscale name in colorscale= to get your heatmap as a function of the z-coordinate. Or you can opt to enter a list of 2 rgb tuples (or normalized rgb tuples, where each coordinate is between 0 and 1).

I also included a doc string which outputs some cool looking plots.

Things I need to do:
-add tests (which I can do now!)
-potential **kwargs

Bring forth your comments!

Kully · 2016-05-03T17:45:33Z

Kully · 2016-05-03T18:33:17Z

Some more color variety for y'all.

jackparmer · 2016-05-03T19:16:45Z

HECK YEAH! These are looking great. Can't wait to replace the mammoth 🐘 we have here:
https://plot.ly/python/trisurf/
With some slick 1 liners :)

theengineear · 2016-05-03T19:44:48Z

plotly/tools.py

@@ -1425,6 +1425,12 @@ def return_figure_from_figure_or_data(figure_or_data, validate_figure):
 _DEFAULT_INCREASING_COLOR = '#3D9970'  # http://clrs.cc
 _DEFAULT_DECREASING_COLOR = '#FF4136'

+DEFAULT_PLOTLY_COLORS = ['rgb(31, 119, 180)', 'rgb(255, 127, 14)',


🐄 This should go to the top of the file. The above constants should have been at the top as well.

theengineear · 2016-05-03T20:27:21Z

@Kully Looking amazing! Mostly small comments about style and organization. Ping me when tests are up for another review!

…ith Python 2, 3.3 and 3.4

In python 3 `map` is a generator, `list()` it!

…nto Trisurf_Plots

Kully · 2016-05-10T14:19:42Z

@theengineear @jackparmer @cldougl @chriddyp

Final something with no errors. Thanks a lot to Andrew for helping me out with this last night.
Checklist:
-Pep-8 compliant
-tests are thorough and work

theengineear · 2016-05-10T14:22:08Z

Great! I'll take a peek today!

theengineear · 2016-05-10T16:33:43Z

plotly/tests/test_optional/test_figure_factory.py

+                              'showbackground': True,
+                              'zerolinecolor': 'rgb(255, 255, 255)'}},
+                            'title': 'Trisurf Plot',
+                            'width': 800}}


😿 Can you reformat this? You could even save on indentation by defining it at the top of the file or something. For example, this would be much better:

{ 'data': [ { 'facecolor': ['rgb(143.0, 123.0, 97.000000000000014)', 'rgb(255.0, 127.0, 14.000000000000007)', 'rgb(143.0, 123.0, 97.000000000000014)', 'rgb(31.0, 119.0, 180.0)', 'rgb(143.0, 123.0, 97.000000000000014)', 'rgb(31.0, 119.0, 180.0)', 'rgb(143.0, 123.0, 97.000000000000014)', 'rgb(255.0, 127.0, 14.000000000000007)'], 'i': [3, 1, 1, 5, 7, 3, 5, 7], 'j': [1, 3, 5, 1, 3, 7, 7, 5], 'k': [4, 0, 4, 2, 4, 6, 4, 8], 'name': '', 'type': 'mesh3d', 'x': np.array([-1., 0., 1., -1., 0., 1., -1., 0., 1.]), 'y': np.array([-1., -1., -1., 0., 0., 0., 1., 1., 1.]), 'z': np.array([ 1., -0., -1., -0., 0., 0., -1., 0., 1.]) }, { 'line': {'color': 'rgb(50, 50, 50)', 'width': 1.5}, 'mode': 'lines', 'type': 'scatter3d', 'x': [-1.0, 0.0, 0.0, -1.0, None, 0.0, -1.0, -1.0, 0.0, None, 0.0, 1.0, 0.0, 0.0, None, 1.0, 0.0, 1.0, 1.0, None, 0.0, -1.0, 0.0, 0.0, None, -1.0, 0.0, -1.0, -1.0, None, 1.0, 0.0, 0.0, 1.0, None, 0.0, 1.0, 1.0, 0.0, None], 'y': [0.0, -1.0, 0.0, 0.0, None, -1.0, 0.0, -1.0, -1.0, None, -1.0, 0.0, 0.0, -1.0, None, 0.0, -1.0, -1.0, 0.0, None, 1.0, 0.0, 0.0, 1.0, None, 0.0, 1.0, 1.0, 0.0, None, 0.0, 1.0, 0.0, 0.0, None, 1.0, 0.0, 1.0, 1.0, None], 'z': [-0.0, -0.0, 0.0, -0.0, None, -0.0, -0.0, 1.0, -0.0, None, -0.0, 0.0, 0.0, -0.0, None, 0.0, -0.0, -1.0, 0.0, None, 0.0, -0.0, 0.0, 0.0, None, -0.0, 0.0, -1.0, -0.0, None, 0.0, 0.0, 0.0, 0.0, None, 0.0, 0.0, 1.0, 0.0, None] } ], 'layout': { 'height': 800, 'scene': {'aspectratio': {'x': 1, 'y': 1, 'z': 1}, 'xaxis': {'backgroundcolor': 'rgb(230, 230, 230)', 'gridcolor': 'rgb(255, 255, 255)', 'showbackground': True, 'zerolinecolor': 'rgb(255, 255, 255)'}, 'yaxis': {'backgroundcolor': 'rgb(230, 230, 230)', 'gridcolor': 'rgb(255, 255, 255)', 'showbackground': True, 'zerolinecolor': 'rgb(255, 255, 255)'}, 'zaxis': {'backgroundcolor': 'rgb(230, 230, 230)', 'gridcolor': 'rgb(255, 255, 255)', 'showbackground': True, 'zerolinecolor': 'rgb(255, 255, 255)'}}, 'title': 'Trisurf Plot', 'width': 800 } }

theengineear · 2016-05-10T16:59:03Z

Still looking good to me! Ping me when you're all finished and I'll give it a final review.

Kully · 2016-05-10T20:04:19Z

@theengineear

jackparmer · 2016-05-10T20:09:56Z

It would be great to do a sanity check making sure this figure_factory
still works smoothly with PLY files.

http://moderndata.plot.ly/visualizing-56-ply-files-in-python/

Is custom surface coloring handled?

https://plot.ly/python/3d-surface-coloring/

On Tue, May 10, 2016 at 9:59 AM, Andrew notifications@github.com wrote:

Still looking good to me! Ping me when you're all finished and I'll give
it a final review.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#453 (comment)

Kully · 2016-05-10T20:21:18Z

It would be great to do a sanity check making sure this figure_factory
still works smoothly with PLY files.

http://moderndata.plot.ly/visualizing-56-ply-files-in-python/

Is custom surface coloring handled?

https://plot.ly/python/3d-surface-coloring/

No, custom coloring isn't handled yet, but I can add.

I can check the PLT files as well.

Kully · 2016-05-10T20:52:29Z

@jackparmer It's more than working... =D

jackparmer · 2016-05-10T21:15:18Z

Awesome - Beethoven in the house! Last thing we need is support for custom
coloring. Lots of customers need coloring to change with a variable that is
not the Z axis.

On Tue, May 10, 2016 at 1:52 PM, Adam Kulidjian notifications@github.com
wrote:

@jackparmer https://github.com/jackparmer It's more than working... =D

[image: trisurf plot - chopper]
https://cloud.githubusercontent.com/assets/10369095/15162147/80a9fe2c-16cf-11e6-9a92-1ce43fbba794.png

[image: trisurf plot - beethoven]
https://cloud.githubusercontent.com/assets/10369095/15162153/84b5118c-16cf-11e6-80dc-77c6cd142a06.png

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#453 (comment)

Kully · 2016-05-10T21:16:37Z

Awesome - Beethoven in the house! Last thing we need is support for custom
coloring. Lots of customers need coloring to change with a variable that is
not the Z axis.

Makes sense and I'm on it.

Kully · 2016-05-11T17:36:51Z

@jackparmer @theengineear @cldougl

I have added the option to write a function dist_func(x, y, z) and input that into the Trisurf function.

A couple notes:
-For my examples in the create_trisurf doc string, they only work in my notebook if I do the usual cd adam/plotly/plotly.py (i.e. move to the appropriate directory). I don't think I had to add something like that for a doc like this, as I imagine the user will have access to the plotly module from anywhere.
-I had previously added a from scipy.spatial import Delaunay line to test_figure_factory.py in test_optional (which was there in the previous PR update) so that my trisurf tests would work. Just a note.

theengineear · 2016-05-12T01:04:48Z

For my examples in the create_trisurf doc string, they only work in my notebook if I do the usual cd adam/plotly/plotly.py (i.e. move to the appropriate directory). I don't think I had to add something like that for a doc like this, as I imagine the user will have access to the plotly module from anywhere.

AH! That's why you don't need the special activate file for your venv. Makes sense! Also, nope, don't include that in the docstring. The user should be A-OK.

I had previously added a from scipy.spatial import Delaunay line to test_figure_factory.py in test_optional (which was there in the previous PR update) so that my trisurf tests would work. Just a note.

Okie dokie.

theengineear · 2016-05-12T01:09:00Z

No new notes from me, I think there are a few code comments in https://github.com/plotly/plotly.py/pull/453/files that were not addressed but nothing major.

Not gonna block this one --> 💃

First Push for Trisurf Plots

866ea46

theengineear reviewed May 3, 2016
View reviewed changes

Kully added 7 commits May 5, 2016 16:44

Added tests and fixed style/organization

273fa2b

Updated Schema

037a89d

Replaced reduce() method because of Python 3.3 Incompatibility

6756fc3

Rewrote reduce() line more explicitly and clearly for compatibility w…

a47b88d

…ith Python 2, 3.3 and 3.4

Try again

5226650

from functools import reduce

bc42794

go back to reduce()

1fe18c2

Kully and others added 4 commits May 10, 2016 09:19

Merge pull request #456 from plotly/fix-empty-generator-in-py3-trisurf

4237742

In python 3 `map` is a generator, `list()` it!

Removed extraneous comment//verified Pep-8 is satisfied

be9112c

Merge branch 'Trisurf_Plots' of https://github.com/plotly/plotly.py i…

4647830

…nto Trisurf_Plots

Fixed up a comment

b1cb22c

theengineear reviewed May 10, 2016
View reviewed changes

Fixed Python doc strings and other formatting/naming/Pep8

8904508

Added custom coloring option

581f8ba

Kully added 2 commits May 12, 2016 12:42

Fixed conflicts

798c387

Fixed stuff

4893444

Kully merged commit 524e4fc into master May 12, 2016

Kully deleted the Trisurf_Plots branch May 12, 2016 22:49

Uh oh!

First Push for Trisurf Plots #453

First Push for Trisurf Plots #453

Uh oh!

Conversation

Kully commented May 3, 2016

Uh oh!

Kully commented May 3, 2016

Uh oh!

Kully commented May 3, 2016

Uh oh!

jackparmer commented May 3, 2016

Uh oh!

theengineear May 3, 2016

Choose a reason for hiding this comment

Uh oh!

theengineear commented May 3, 2016

Uh oh!

Kully commented May 10, 2016

Uh oh!

theengineear commented May 10, 2016

Uh oh!

theengineear May 10, 2016

Choose a reason for hiding this comment

Uh oh!

theengineear commented May 10, 2016

Uh oh!

Kully commented May 10, 2016

Uh oh!

jackparmer commented May 10, 2016

Uh oh!

Kully commented May 10, 2016

Uh oh!

Kully commented May 10, 2016

Uh oh!

jackparmer commented May 10, 2016

Uh oh!

Kully commented May 10, 2016

Uh oh!

Kully commented May 11, 2016

Uh oh!

theengineear commented May 12, 2016

Uh oh!

theengineear commented May 12, 2016

Uh oh!

Uh oh!