Skip to content

Update CI #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 4, 2023
Merged

Update CI #4188

merged 11 commits into from
May 4, 2023

Conversation

alexcjohnson
Copy link
Collaborator

Bunch of CI config updates... the error in #4165 was actually fixed by downgrading Node from 18 to 16, somehow the Node 18 we're getting on CI can't handle named unicode properties in regex even though Node 18 on my mac does that fine, but Node 16 on CI seems to work. I also upgraded to the cimg/python images, somewhere in there black noticed a couple more files, pdftops changed versions, and on Py36 now we need to explicitly install packaging (it was probably part of the base image before, and we weren't using a venv on CI, now we are).

@LiamConnors I'm getting an error still in build-doc:

make: *** [Makefile:40: build/html/2019-07-03-static-image-export.html] Error 1

Do you know how to fix that? Otherwise all the tests are now passing on this branch.

@alexcjohnson
Copy link
Collaborator Author

Hmph the Percy snapshots are also messed up... lots of images are way too narrow, others are unfinished, like we didn't wait for WebGL to render. That said some of the previous baselines also seem to have WebGL unrendered... and some of the narrow ones, the 375px image looks correct now but clipped previously, whereas the 1280px image looked correct previously. Did we actually intend to have Percy do both widths or is that a mistake? If we're only generating one width in the test we should ask Percy to only render at that same width, having Percy render multiple widths only makes sense for pages that can adapt purely via CSS.

@alexcjohnson
Copy link
Collaborator Author

We're still losing WebGL from the Percy images, even when I try to use the trick from Dash of replacing the <canvas> elements with <img> elements. Not sure if the wait I'm doing isn't long enough (or isn't working), or if we just aren't rendering WebGL at all in the updated container. Whatever, doesn't seem like this is actually that important a test, and it was already failing for some of the 3D WebGL plots. And I finally did succeed in dropping to a single width in Percy (and a single Browser).

the build-doc error was from pdf -> eps conversion failing, seems like I didn't get the right utils installed in that container. But we don't really need to run those code cells at all since they produce no output, so I disabled them by changing:

```python
fig.write_image("images/fig1.eps")
```

to:

~~~python
fig.write_image("images/fig1.eps")
~~~

Which should look the same on the docs site. It'll look different in Binder - rather than a separate code cell it'll just look like part of the markdown - but that's OK for now. These notebooks are broken in Binder anyway... something about our pinned numpy and Py3.10.

@alexcjohnson alexcjohnson merged commit 3eb3ee4 into master May 4, 2023
@alexcjohnson alexcjohnson deleted the update-ci-images branch May 4, 2023 22:31
@nicolaskruchten
Copy link
Contributor

FWIW I've been approving Percy snapshots with empty WebGL plots... I just look at the legend and occasionally spot check. And I've tolerated the width flakiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants