-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update CI #4188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #4188
Conversation
Hmph the Percy snapshots are also messed up... lots of images are way too narrow, others are unfinished, like we didn't wait for WebGL to render. That said some of the previous baselines also seem to have WebGL unrendered... and some of the narrow ones, the 375px image looks correct now but clipped previously, whereas the 1280px image looked correct previously. Did we actually intend to have Percy do both widths or is that a mistake? If we're only generating one width in the test we should ask Percy to only render at that same width, having Percy render multiple widths only makes sense for pages that can adapt purely via CSS. |
We're still losing WebGL from the Percy images, even when I try to use the trick from Dash of replacing the the
to:
Which should look the same on the docs site. It'll look different in Binder - rather than a separate code cell it'll just look like part of the markdown - but that's OK for now. These notebooks are broken in Binder anyway... something about our pinned numpy and Py3.10. |
FWIW I've been approving Percy snapshots with empty WebGL plots... I just look at the legend and occasionally spot check. And I've tolerated the width flakiness. |
Bunch of CI config updates... the error in #4165 was actually fixed by downgrading Node from 18 to 16, somehow the Node 18 we're getting on CI can't handle named unicode properties in regex even though Node 18 on my mac does that fine, but Node 16 on CI seems to work. I also upgraded to the
cimg/python
images, somewhere in thereblack
noticed a couple more files,pdftops
changed versions, and on Py36 now we need to explicitly installpackaging
(it was probably part of the base image before, and we weren't using avenv
on CI, now we are).@LiamConnors I'm getting an error still in
build-doc
:Do you know how to fix that? Otherwise all the tests are now passing on this branch.